Subject: re: net: return actual error on register_queue_kobjects

From: Dan Carpenter <[email-masked]>
Date: Fri, 20 Jun 2014 00:28:40 +0300

Hello Jie Liu,

The patch d36a4f4b4723: "net: return actual error on
register_queue_kobjects" from Jun 17, 2014, leads to the following
static checker warning:

	net/core/net-sysfs.c:1203 register_queue_kobjects()
	warn: 'net->queues_kset' isn't an ERR_PTR

net/core/net-sysfs.c
  1200  #ifdef CONFIG_SYSFS
  1201          net->queues_kset = kset_create_and_add("queues",
                                   ^^^^^^^^^^^^^^^^^^^
This function returns a NULL on error doesn't it?  In linux-next it
does.  The patch description is not clear.

  1202              NULL, &net->dev.kobj);
  1203          if (IS_ERR(net->queues_kset))
  1204                  return PTR_ERR(net->queues_kset);
  1205          real_rx = net->real_num_rx_queues;
  1206  #endif

regards,
dan carpenter