Subject: Re: [PATCH net-next 1/3] ptp: Allow reassigning calibration pin function

From: Richard Cochran <[email-masked]>
Date: Thu, 26 Jun 2014 07:21:45 +0200

On Wed, Jun 25, 2014 at 02:37:29PM +0200, Stefan Sørensen wrote:
> The ptp pin function programming does not allow calibration pin to change
> function. This is problematic on hardware that uses the default calibration
> pin for other purposes.
> 
> Removing this limitation does not impact calibration if userspace does not
> reprogram the calibration pin.

Reassigning the calibration function never makes sense, because it is
only used in the driver probe method.

Clobbering the calibration pin with another function only makes sense
if the hardware design has exactly one PHY.

Can you please add a check in the dp83640 verify method to enforce
these two constraints?

Thanks,
Richard