Subject: Re: [PATCH] bonding: Do not try to send packets over dead link in TLB mode.

From: Veaceslav Falico <[email-masked]>
Date: Wed, 9 Jul 2014 14:04:37 +0200

On Wed, Jul 09, 2014 at 12:25:43PM +0200, Nikolay Aleksandrov wrote:
>On 07/09/2014 12:24 PM, Veaceslav Falico wrote:
>> On Tue, Jul 08, 2014 at 06:09:58PM -0700, Mahesh Bandewar wrote:
...snip...
>>> +    spin_lock(&bond_info->slave_arr_lock);
>>
>> I don't think you can re-enter bond_alb_handle_link_change(), as it's
>> protected either by rtnl or write-lock curr_active_slave.
>>
>Actually a very good catch :-)
>Maybe the allocation above should be done with GFP_ATOMIC.

For the record - it's indeed always under rtnl, so ASSERT_RTNL() (from your
other email) is a good idea.