From: Felipe Balbi <balbi@ti•com>
To: <varkabhadram@gmail•com>
Cc: <netdev@vger•kernel.org>, <mugunthanvnm@ti•com>,
<linux@rainbow-software•org>, <balbi@ti•com>,
<george.cherian@ti•com>, <davem@davemloft•net>,
Varka Bhadram <varkab@cdac•in>
Subject: Re: [PATCH net v2 4/7] net: cpmac: fix cpmac driver structure
Date: Thu, 10 Jul 2014 08:08:12 -0500 [thread overview]
Message-ID: <20140710130812.GD15340@saruman.home> (raw)
In-Reply-To: <1404970545-26508-5-git-send-email-varkabhadram@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]
On Thu, Jul 10, 2014 at 11:05:42AM +0530, varkabhadram@gmail•com wrote:
> From: Varka Bhadram <varkab@cdac•in>
>
> This patch changes to style of declarattion which follows every driver
>
> Signed-off-by: Varka Bhadram <varkab@cdac•in>
Reviewed-by: Felipe Balbi <balbi@ti•com>
> ---
> drivers/net/ethernet/ti/cpmac.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c
> index 9faf669..1520c19 100644
> --- a/drivers/net/ethernet/ti/cpmac.c
> +++ b/drivers/net/ethernet/ti/cpmac.c
> @@ -1187,9 +1187,11 @@ static int cpmac_remove(struct platform_device *pdev)
> }
>
> static struct platform_driver cpmac_driver = {
> - .driver.name = "cpmac",
> - .driver.owner = THIS_MODULE,
> - .probe = cpmac_probe,
> + .driver = {
> + .name = "cpmac",
> + .owner = THIS_MODULE,
> + },
> + .probe = cpmac_probe,
> .remove = cpmac_remove,
> };
>
> --
> 1.7.9.5
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-07-10 13:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 5:35 [PATCH net v2 0/7] cleanup for AR7 CPMAC Ethernet controller driver varkabhadram
2014-07-10 5:35 ` [PATCH net v2 1/7] net: cpmac: remove space in macro defination varkabhadram
2014-07-10 13:07 ` Felipe Balbi
2014-07-10 5:35 ` [PATCH net v2 2/7] net: cpmac: fix comments varkabhadram
2014-07-10 13:07 ` Felipe Balbi
2014-07-10 5:35 ` [PATCH net v2 3/7] net: cpmac: dynamic debug fixes varkabhadram
2014-07-10 8:31 ` Joe Perches
2014-07-10 8:45 ` Varka Bhadram
2014-07-10 9:03 ` Joe Perches
2014-07-10 9:35 ` Varka Bhadram
2014-07-10 10:10 ` Joe Perches
2014-07-10 10:11 ` Varka Bhadram
2014-07-10 10:17 ` Joe Perches
2014-07-10 13:08 ` Felipe Balbi
2014-07-10 5:35 ` [PATCH net v2 4/7] net: cpmac: fix cpmac driver structure varkabhadram
2014-07-10 13:08 ` Felipe Balbi [this message]
2014-07-10 5:35 ` [PATCH net v2 5/7] net: cpmac: fix missing a blank line after declarations varkabhadram
2014-07-10 13:08 ` Felipe Balbi
2014-07-10 5:35 ` [PATCH net v2 6/7] net: cpmac: fix proper spacing before return statement varkabhadram
2014-07-10 13:09 ` Felipe Balbi
2014-07-10 5:35 ` [PATCH net v2 7/7] net: cpmac: fix in releasing resources varkabhadram
2014-07-10 13:11 ` Felipe Balbi
2014-07-10 7:41 ` [PATCH net v2 0/7] cleanup for AR7 CPMAC Ethernet controller driver David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710130812.GD15340@saruman.home \
--to=balbi@ti$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=george.cherian@ti$(echo .)com \
--cc=linux@rainbow-software$(echo .)org \
--cc=mugunthanvnm@ti$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=varkab@cdac$(echo .)in \
--cc=varkabhadram@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox