Subject: Re: [PATCH net-next 5/9] inet: frag: don't account number of fragment queues

From: Florian Westphal <[email-masked]>
Date: Fri, 25 Jul 2014 10:32:05 +0200

David Miller <[email-masked]> wrote:
> From: Nikolay Aleksandrov <[email-masked]>
> Date: Thu, 24 Jul 2014 16:50:33 +0200
> 
> > From: Florian Westphal <[email-masked]>
> > 
> > The 'nqueues' counter is protected by the lru list lock,
> > once thats removed this needs to be converted to atomic
> > counter.  Given this isn't used for anything except for
> > reporting it to userspace via /proc, just remove it.
> > 
> > We still report the memory currently used by fragment
> > reassembly queues.
> > 
> > Signed-off-by: Florian Westphal <[email-masked]>
> 
> It's a user visible value, you can't just change it's semantics.

Really?  It won't break scripts.
In my tests this never reported any useful information to me.

If you insist, we can keep this but it seems silly to me to add atomic
ops just for this one counter which - IMO - does not provide
any useful information.