From: Richard Cochran <richardcochran@gmail•com>
To: Fugang Duan <b38611@freescale•com>
Cc: shawn.guo@linaro•org, davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCH v2 1/1] net: fec: ptp: avoid register access when ipg clock is disabled
Date: Wed, 13 Aug 2014 23:19:42 +0200 [thread overview]
Message-ID: <20140813211941.GB4840@netboy> (raw)
In-Reply-To: <1407905705-27984-2-git-send-email-b38611@freescale.com>
On Wed, Aug 13, 2014 at 12:55:05PM +0800, Fugang Duan wrote:
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index 66fe1f6..8befa2c 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2198,6 +2198,8 @@ fec_enet_open(struct net_device *ndev)
> napi_enable(&fep->napi);
> phy_start(fep->phy_dev);
> netif_start_queue(ndev);
> + if (fep->hwts_tx_en)
> + schedule_delayed_work(&fep->time_keep, HZ);
> return 0;
> }
>
> @@ -2206,6 +2208,9 @@ fec_enet_close(struct net_device *ndev)
> {
> struct fec_enet_private *fep = netdev_priv(ndev);
>
> + if (fep->hwts_tx_en)
> + cancel_delayed_work_sync(&fep->time_keep);
You make the clock logic depend on whether time stamping is enabled or
not. Why do you do that?
The clock should keep ticking, even if time stamping is disabled.
Thanks,
Richard
next prev parent reply other threads:[~2014-08-13 21:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 4:55 [PATCH v2 0/1] net: fec: ptp: avoid register access when ipg clock is disabled Fugang Duan
2014-08-13 4:55 ` [PATCH v2 1/1] " Fugang Duan
2014-08-13 21:19 ` Richard Cochran [this message]
2014-08-14 1:28 ` fugang.duan
2014-08-14 8:10 ` Richard Cochran
2014-08-14 8:24 ` fugang.duan
2014-08-14 8:42 ` Richard Cochran
2014-08-14 9:02 ` fugang.duan
2014-08-14 9:12 ` Richard Cochran
2014-08-14 9:26 ` fugang.duan
2014-08-14 14:33 ` Richard Cochran
2014-08-15 3:23 ` fugang.duan
-- strict thread matches above, loose matches on Subject: below --
2021-02-25 20:55 Heiko Thiery
2021-02-25 22:34 ` kernel test robot
2021-02-25 21:15 Heiko Thiery
2021-02-26 7:22 ` Heiko Thiery
2021-02-26 15:23 ` Richard Cochran
2021-02-26 23:44 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140813211941.GB4840@netboy \
--to=richardcochran@gmail$(echo .)com \
--cc=b38611@freescale$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shawn.guo@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox