Subject: Re: [PATCH v2 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

From: Richard Cochran <[email-masked]>
Date: Thu, 14 Aug 2014 10:42:51 +0200

On Thu, Aug 14, 2014 at 08:24:39AM +0000, [email-masked] wrote:
> 1. HW ptp is one feature of FEC IP, when the ethx interface is closed, ptp slave cannot sync with master,
>    So the ptp timer is not accurate, of couse there have discontinuities in ptp clock.

No, it just becomes a free running clock.

This is no different than the Linux system clock. It keeps running,
even if ntpd is not.

> 2. When the ethx net interface is closed, FEC IP clocks are disabled, access ptp counter register causes
>    Hw hang.

Well, then, you need to return an error, don't you?

> 3. PTP is not separate HW IP, which is one hw feature of FEC IP, when the net interface is closed, user
>    Call clock_gettime() is not reasonable.

Yes, it is. See #1.

Thanks,
Richard