Subject: Re: [PATCH v2 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

From: Richard Cochran <[email-masked]>
Date: Thu, 14 Aug 2014 11:12:59 +0200

On Thu, Aug 14, 2014 at 09:02:07AM +0000, [email-masked] wrote:
> 
> I know your means. Even if cancel the time_keep work, ptp timer still is running and continutious.
> The time_keep work just to avoid timer overrun because FEC just support 32bit counter.

Right, so the time_keep must continue when the clock is running. It
does not depend on whether time stamping is enabled.

> And, you said "return an error", I don't know your mean.
> In addition, when clock is disabled, FEC ptp counter don't run any more.

You can return an error from your 'gettime' method.

Thanks,
Richard