Subject: Re: [PATCH v2 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

From: Richard Cochran <[email-masked]>
Date: Thu, 14 Aug 2014 16:33:51 +0200

On Thu, Aug 14, 2014 at 09:26:45AM +0000, [email-masked] wrote:
> When ethx disable, all clocks are disabled. For gettime(), your mean that we check clock is on or not,
> If clock is disabled, return an error in .fec_ptp_gettime() ?

Yes.

> How did it in the delayed work ?

The work must run whenever the physical clock is runnning.

This is COMPLETELY INDEPENDENT from time stamping.

If your patch has anything with "fep->hwts_tx_en", then it is wrong.

> Thanks for your review, I am confused by your suggestion.

Just start and stop the work queue when you start and stop the
physical clock.

Is it clear now?

Thanks,
Richard