From: "gregkh@linuxfoundation•org" <gregkh@linuxfoundation•org>
To: "Luis R. Rodriguez" <mcgrof@suse•com>
Cc: One Thousand Gnomes <gnomes@lxorguk•ukuu.org.uk>,
"tiwai@suse•de" <tiwai@suse•de>, Kay Sievers <kay@vrfy•org>,
Sreekanth Reddy <sreekanth.reddy@avagotech•com>,
Praveen Krishnamoorthy <praveen.krishnamoorthy@avagotech•com>,
Nagalakshmi Nandigama <nagalakshmi.nandigama@avagotech•com>,
Tetsuo Handa <penguin-kernel@I-love•SAKURA.ne.jp>,
"MPT-FusionLinux.pdl@avagotech•com"
<MPT-FusionLinux.pdl@avagotech•com>,
Tim Gardner <tim.gardner@canonical•com>,
Benjamin Poirier <bpoirier@suse•de>,
Santosh Rastapur <santosh@chelsio•com>,
Casey Leedom <leedom@chelsio•com>,
Hariprasad S <hariprasad@chelsio•com>,
Pierre Fersing <pierre-fersing@pierref•org>,
Anish Bhatt <anish@chelsio•com>, Oleg Nesterov <oleg@redhat•com>,
Abhijit Mahajan <abhijit.mahajan@avagotech•com>,
systemd-devel@lists•freedesktop.org,
"linux-scsi@vger•kernel.org" <linux-scsi@vger•kernel.org>,
"netdev@vger•kernel.org"
Subject: Re: [PATCH v3 2/3] cxgb4: use module_long_probe_init()
Date: Fri, 15 Aug 2014 15:12:05 +0800 [thread overview]
Message-ID: <20140815071205.GA6293@kroah.com> (raw)
In-Reply-To: <20140815001458.GT21930@wotan.suse.de>
On Fri, Aug 15, 2014 at 02:14:58AM +0200, Luis R. Rodriguez wrote:
> This driver also uses module_pci_driver() so a module_long_probe_driver()
> and respective module_long_probe_pci_driver() would need to be considered
> if but easily implemented (sent to Alex to test).
No, don't create bus-only versions of the "long probe" function, just
unwrap the module_pci_driver() logic and use the module_long_probe()
call, we want it to be "obvious" that something is odd here and needs to
be fixed someday.
thanks,
greg k-h
next prev parent reply other threads:[~2014-08-15 7:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1407882507-325-1-git-send-email-mcgrof@do-not-panic.com>
2014-08-12 22:28 ` [PATCH v3 1/3] init / kthread: add module_long_probe_init() and module_long_probe_exit() Luis R. Rodriguez
2014-08-12 22:59 ` Tetsuo Handa
2014-08-13 1:03 ` Greg KH
2014-08-13 17:51 ` Oleg Nesterov
2014-08-14 23:10 ` Luis R. Rodriguez
2014-08-15 14:39 ` Oleg Nesterov
2014-08-16 2:50 ` Luis R. Rodriguez
2014-08-17 6:59 ` Takashi Iwai
2014-08-17 12:25 ` Oleg Nesterov
2014-08-17 12:48 ` Oleg Nesterov
2014-08-17 12:55 ` Oleg Nesterov
2014-08-17 17:46 ` Luis R. Rodriguez
2014-08-17 18:21 ` Oleg Nesterov
2014-08-18 8:52 ` Takashi Iwai
2014-08-18 12:22 ` Oleg Nesterov
2014-08-18 13:20 ` Takashi Iwai
2014-08-18 15:19 ` Oleg Nesterov
2014-08-19 4:11 ` Luis R. Rodriguez
2014-08-12 22:28 ` [PATCH v3 2/3] cxgb4: use module_long_probe_init() Luis R. Rodriguez
2014-08-13 23:33 ` Anish Bhatt
2014-08-14 16:42 ` Casey Leedom
2014-08-14 19:53 ` Luis R. Rodriguez
2014-08-15 0:14 ` Luis R. Rodriguez
2014-08-15 7:12 ` gregkh [this message]
[not found] ` <53EE4E24.9020104@chelsio.com>
2014-08-17 5:02 ` Luis R. Rodriguez
2014-08-12 22:28 ` [PATCH v3 3/3] mptsas: " Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140815071205.GA6293@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=MPT-FusionLinux.pdl@avagotech$(echo .)com \
--cc=abhijit.mahajan@avagotech$(echo .)com \
--cc=anish@chelsio$(echo .)com \
--cc=bpoirier@suse$(echo .)de \
--cc=gnomes@lxorguk$(echo .)ukuu.org.uk \
--cc=hariprasad@chelsio$(echo .)com \
--cc=kay@vrfy$(echo .)org \
--cc=leedom@chelsio$(echo .)com \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=mcgrof@suse$(echo .)com \
--cc=nagalakshmi.nandigama@avagotech$(echo .)com \
--cc=oleg@redhat$(echo .)com \
--cc=penguin-kernel@I-love$(echo .)SAKURA.ne.jp \
--cc=pierre-fersing@pierref$(echo .)org \
--cc=praveen.krishnamoorthy@avagotech$(echo .)com \
--cc=santosh@chelsio$(echo .)com \
--cc=sreekanth.reddy@avagotech$(echo .)com \
--cc=systemd-devel@lists$(echo .)freedesktop.org \
--cc=tim.gardner@canonical$(echo .)com \
--cc=tiwai@suse$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox