From: Jiri Pirko <jiri@resnulli•us>
To: Nikolay Aleksandrov <nikolay@redhat•com>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
Jay Vosburgh <j.vosburgh@gmail•com>,
Veaceslav Falico <vfalico@gmail•com>,
Andy Gospodarek <andy@greyhouse•net>
Subject: Re: [PATCH net-next] bonding: add slave_changelink support and use it for queue_id
Date: Wed, 27 Aug 2014 16:29:57 +0200 [thread overview]
Message-ID: <20140827142957.GA1908@nanopsycho.lan> (raw)
In-Reply-To: <1409148406-5576-1-git-send-email-nikolay@redhat.com>
Wed, Aug 27, 2014 at 04:06:46PM CEST, nikolay@redhat•com wrote:
>This patch adds support for slave_changelink to the bonding and uses it
>to give the ability to change the queue_id of the enslaved devices via
>netlink. It sets slave_maxtype and uses bond_changelink as a prototype for
>bond_slave_changelink.
>Example/test command after the iproute2 patch:
> ip link set eth0 type bond_slave queue_id 10
>
>CC: David S. Miller <davem@davemloft•net>
>CC: Jay Vosburgh <j.vosburgh@gmail•com>
>CC: Veaceslav Falico <vfalico@gmail•com>
>CC: Andy Gospodarek <andy@greyhouse•net>
>
>Suggested-by: Jiri Pirko <jiri@resnulli•us>
>Signed-off-by: Nikolay Aleksandrov <nikolay@redhat•com>
>---
>note: I intend to add a new option flag to indicate it's a slave option
> so a new netdev notifier can be called (NETDEV_CHANGESLAVEINFODATA).
No need fo that atm.
> I believe the bonding is the first user of slave_changelink so I hope
> I haven't missed anything. Once this patch is accepted in some form
> I'll post the iproute2 one.
This patch is looking good to me.
Acked-by: Jiri Pirko <jiri@resnulli•us>
next prev parent reply other threads:[~2014-08-27 14:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 14:06 [PATCH net-next] bonding: add slave_changelink support and use it for queue_id Nikolay Aleksandrov
2014-08-27 14:29 ` Jiri Pirko [this message]
2014-08-29 11:27 ` Nikolay Aleksandrov
2014-09-02 1:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140827142957.GA1908@nanopsycho.lan \
--to=jiri@resnulli$(echo .)us \
--cc=andy@greyhouse$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=j.vosburgh@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@redhat$(echo .)com \
--cc=vfalico@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox