From: Stephen Hemminger <stephen@networkplumber•org>
To: davem@davemloft•net
Cc: netdev@vger•kernel.org, Stephen Hemminger <stephen@networkplumber•org>
Subject: [PATCH net-next 5/5] sched: replace bare printks
Date: Fri, 29 Aug 2014 00:09:23 -0700 [thread overview]
Message-ID: <20140829071035.547171617@networkplumber.org> (raw)
In-Reply-To: 20140829070918.508987897@networkplumber.org
[-- Attachment #1: act-msg.patch --]
[-- Type: text/plain, Size: 1636 bytes --]
Don't use bare printk for error messages.
Make GRED error an info level message rather than debug which
is likely to be suppressed.
Signed-off-by: Stephen Hemminger <stephen@networkplumber•org>
--- a/net/sched/act_ipt.c 2014-03-28 11:40:43.000000000 -0700
+++ b/net/sched/act_ipt.c 2014-08-22 16:53:33.676030680 -0700
@@ -290,10 +290,10 @@ static int __init ipt_init_module(void)
ret1 = tcf_register_action(&act_xt_ops, IPT_TAB_MASK);
if (ret1 < 0)
- printk("Failed to load xt action\n");
+ pr_err("Failed to load xt action\n");
ret2 = tcf_register_action(&act_ipt_ops, IPT_TAB_MASK);
if (ret2 < 0)
- printk("Failed to load ipt action\n");
+ pr_err("Failed to load ipt action\n");
if (ret1 < 0 && ret2 < 0) {
return ret1;
--- a/net/sched/act_mirred.c 2014-08-12 13:07:42.000000000 -0700
+++ b/net/sched/act_mirred.c 2014-08-22 16:54:07.244031579 -0700
@@ -140,7 +140,7 @@ static int tcf_mirred(struct sk_buff *sk
dev = m->tcfm_dev;
if (!dev) {
- printk_once(KERN_NOTICE "tc mirred: target device is gone\n");
+ netdev_notice(dev, "tc mirred: target device is gone\n");
goto out;
}
--- a/net/sched/sch_gred.c 2014-03-28 11:40:43.000000000 -0700
+++ b/net/sched/sch_gred.c 2014-08-22 16:54:47.720032663 -0700
@@ -456,8 +456,8 @@ static int gred_change(struct Qdisc *sch
if (table->tab[table->def])
def_prio = table->tab[table->def]->prio;
- printk(KERN_DEBUG "GRED: DP %u does not have a prio "
- "setting default to %d\n", ctl->DP, def_prio);
+ pr_info("GRED: DP %u does not have a prio "
+ "setting default to %d\n", ctl->DP, def_prio);
prio = def_prio;
} else
next prev parent reply other threads:[~2014-08-29 7:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 7:09 [PATCH net-next 0/5] printk message cleanup's Stephen Hemminger
2014-08-29 7:09 ` [PATCH net-next 1/5] net: fix message priorities Stephen Hemminger
2014-08-29 7:09 ` [PATCH net-next 2/5] tcp: silence useless debug message Stephen Hemminger
2014-08-29 7:09 ` [PATCH net-next 3/5] ipv6: silence tunnel loading messages Stephen Hemminger
2014-08-29 7:09 ` [PATCH net-next 4/5] xfrm: replace printk with pr_ macro Stephen Hemminger
2014-08-29 7:09 ` Stephen Hemminger [this message]
2014-08-29 20:12 ` [PATCH net-next 5/5] sched: replace bare printks Michael Heimpold
2014-09-02 1:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140829071035.547171617@networkplumber.org \
--to=stephen@networkplumber$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox