From: Steffen Klassert <steffen.klassert@secunet•com>
To: Ying Xue <ying.xue@windriver•com>
Cc: <davem@davemloft•net>, <christophe.gouault@6wind•com>,
<netdev@vger•kernel.org>
Subject: Re: [PATCH net-next v3] xfrm: remove useless hash_resize_mutex locks
Date: Mon, 1 Sep 2014 13:29:44 +0200 [thread overview]
Message-ID: <20140901112944.GG6390@secunet.com> (raw)
In-Reply-To: <1409303348-23262-1-git-send-email-ying.xue@windriver.com>
On Fri, Aug 29, 2014 at 05:09:07PM +0800, Ying Xue wrote:
> In xfrm_state.c, hash_resize_mutex is defined as a local variable
> and only used in xfrm_hash_resize() which is declared as a work
> handler of xfrm.state_hash_work. But when the xfrm.state_hash_work
> work is put in the global workqueue(system_wq) with schedule_work(),
> the work will be really inserted in the global workqueue if it was
> not already queued, otherwise, it is still left in the same position
> on the the global workqueue. This means the xfrm_hash_resize() work
> handler is only executed once at any time no matter how many times
> its work is scheduled, that is, xfrm_hash_resize() is not called
> concurrently at all, so hash_resize_mutex is redundant for us.
>
> Cc: Christophe Gouault <christophe.gouault@6wind•com>
> Cc: Steffen Klassert <steffen.klassert@secunet•com>
> Signed-off-by: Ying Xue <ying.xue@windriver•com>
> Acked-by: David S. Miller <davem@davemloft•net>
Applied to ipsec-next, thanks!
prev parent reply other threads:[~2014-09-01 11:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 9:09 [PATCH net-next v3] xfrm: remove useless hash_resize_mutex locks Ying Xue
2014-09-01 11:29 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140901112944.GG6390@secunet.com \
--to=steffen.klassert@secunet$(echo .)com \
--cc=christophe.gouault@6wind$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ying.xue@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox