Subject: Re: [net-next PATCH 2/3] qdisc: bulk dequeue support for qdiscs with TCQ_F_ONETXQUEUE

From: Jesper Dangaard Brouer <[email-masked]>
Date: Wed, 3 Sep 2014 14:27:14 +0200

On Tue, 02 Sep 2014 18:14:36 +0200
Daniel Borkmann <[email-masked]> wrote:

> On 09/02/2014 04:35 PM, Jesper Dangaard Brouer wrote:
>
> > This patch implements qdisc bulk dequeue, by allowing multiple packets
> > to be dequeued in dequeue_skb().
> >
[...]
 
> This check should better be an inline for sch_generic.h, e.g. ...
> 
> static inline bool qdisc_may_bulk(const struct Qdisc *qdisc,
> 				  const struct sk_buff *skb)
> {
> 	return (qdisc->flags & TCQ_F_ONETXQUEUE) && !skb->next;
> }

Good ideas of inlining these functions, it should help readability of
the code, thanks.

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Sr. Network Kernel Developer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer