From: raj@tardy•usa.hp.com (Rick Jones)
To: <netdev@vger•kernel.org>
Cc: <amirv@mellanox•com>, <davem@davemloft•net>
Subject: [PATCH net-next] mlx4_en: Convert the normal skb free path to dev_consume_skb_any()
Date: Wed, 3 Sep 2014 09:18:00 -0700 (PDT) [thread overview]
Message-ID: <20140903161800.301F629002CD@tardy> (raw)
From: Rick Jones <rick.jones2@hp•com>
It would appear the mlx4_en driver was still making a call to
dev_kfree_skb_any() where dev_consume_skb_any() would be more
appropriate. This should make dropped packet profiling/tracking
easier/better over a NIC driven by mlx4_en.
Signed-off-by: Rick Jones <rick.jones2@hp•com>
---
Compile tested only
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
index dae3da6..bc8f51c 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
@@ -319,7 +319,7 @@ static u32 mlx4_en_free_tx_desc(struct mlx4_en_priv *priv,
}
}
}
- dev_kfree_skb_any(skb);
+ dev_consume_skb_any(skb);
return tx_info->nr_txbb;
}
next reply other threads:[~2014-09-03 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 16:18 Rick Jones [this message]
2014-09-03 17:53 ` [PATCH net-next] mlx4_en: Convert the normal skb free path to dev_consume_skb_any() Eric Dumazet
2014-09-04 4:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140903161800.301F629002CD@tardy \
--to=raj@tardy$(echo .)usa.hp.com \
--cc=amirv@mellanox$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox