From: raj@tardy•usa.hp.com (Rick Jones)
To: <netdev@vger•kernel.org>
Cc: <davem@davemloft•net>, <sshah@solarflare•com>,
<linux-net-drivers@solarflare•com>
Subject: [PATCH net-next] sfc: Convert the normal transmit complete path to dev_consume_skb_any()
Date: Tue, 9 Sep 2014 14:43:27 -0700 (PDT) [thread overview]
Message-ID: <20140909214327.D474F290042C@tardy> (raw)
From: Rick Jones <rick.jones2@hp•com>
Convert the normal transmit completion path from dev_kfree_skb_any()
to dev_consume_skb_any() to help keep dropped packet profiling
meaningful.
Signed-off-by: Rick Jones <rick.jones2@hp•com>
---
Compile tested only. Also a fixup to make scripts/checkpatch.pl
happy.
diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c
index 65c220f..3206098 100644
--- a/drivers/net/ethernet/sfc/tx.c
+++ b/drivers/net/ethernet/sfc/tx.c
@@ -78,7 +78,7 @@ static void efx_dequeue_buffer(struct efx_tx_queue *tx_queue,
if (buffer->flags & EFX_TX_BUF_SKB) {
(*pkts_compl)++;
(*bytes_compl) += buffer->skb->len;
- dev_kfree_skb_any((struct sk_buff *) buffer->skb);
+ dev_consume_skb_any((struct sk_buff *)buffer->skb);
netif_vdbg(tx_queue->efx, tx_done, tx_queue->efx->net_dev,
"TX queue %d transmission id %x complete\n",
tx_queue->queue, tx_queue->read_count);
next reply other threads:[~2014-09-09 21:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 21:43 Rick Jones [this message]
2014-09-09 23:18 ` [PATCH net-next] sfc: Convert the normal transmit complete path to dev_consume_skb_any() Eric Dumazet
2014-09-09 23:38 ` Rick Jones
2014-09-09 23:46 ` David Miller
2014-09-10 0:25 ` Eric Dumazet
2014-09-10 0:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909214327.D474F290042C@tardy \
--to=raj@tardy$(echo .)usa.hp.com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-net-drivers@solarflare$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sshah@solarflare$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox