From: Steffen Klassert <steffen.klassert@secunet•com>
To: Konstantinos Kolelis <k.kolelis@sirrix•com>
Cc: <netdev@vger•kernel.org>, <davem@davemloft•net>,
<kuznet@ms2•inr.ac.ru>, <jmorris@namei•org>,
<yoshfuji@linux-ipv6•org>, <kaber@trash•net>,
<herbert@gondor•apana.org.au>
Subject: Re: [BUG REPORT] Unencrypted packets after SNAT, allthough IPSEC-Policies are present
Date: Mon, 15 Sep 2014 14:04:07 +0200 [thread overview]
Message-ID: <20140915120407.GQ6390@secunet.com> (raw)
In-Reply-To: <20140915080941.GP6390@secunet.com>
On Mon, Sep 15, 2014 at 10:09:41AM +0200, Steffen Klassert wrote:
>
> diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
> index beeed60..e041822 100644
> --- a/net/xfrm/xfrm_policy.c
> +++ b/net/xfrm/xfrm_policy.c
> @@ -2138,7 +2138,8 @@ struct dst_entry *xfrm_lookup(struct net *net, struct dst_entry *dst_orig,
> xfrm_pols_put(pols, drop_pols);
> XFRM_INC_STATS(net, LINUX_MIB_XFRMOUTNOSTATES);
>
> - return make_blackhole(net, family, dst_orig);
> + err = -EREMOTE;
> + goto error;
We must return here, otherwise we drop some refcounts too much.
I'll send an updated patch tomorrow.
next prev parent reply other threads:[~2014-09-15 12:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 17:26 [BUG REPORT] Unencrypted packets after SNAT, allthough IPSEC-Policies are present Konstantinos Kolelis
2014-09-11 11:54 ` Steffen Klassert
2014-09-11 13:11 ` Konstantinos Kolelis
2014-09-12 9:31 ` Steffen Klassert
2014-09-15 8:09 ` Steffen Klassert
2014-09-15 12:04 ` Steffen Klassert [this message]
2014-09-16 7:30 ` Steffen Klassert
2014-09-16 8:39 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915120407.GQ6390@secunet.com \
--to=steffen.klassert@secunet$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=jmorris@namei$(echo .)org \
--cc=k.kolelis@sirrix$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=netdev@vger$(echo .)kernel.org \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox