From: John Fastabend <john.fastabend@gmail•com>
To: xiyou.wangcong@gmail•com, davem@davemloft•net, eric.dumazet@gmail•com
Cc: netdev@vger•kernel.org, jhs@mojatatu•com
Subject: [net-next PATCH v2] net: sched: cls_u32: rcu can not be last node
Date: Wed, 17 Sep 2014 10:31:14 -0700 [thread overview]
Message-ID: <20140917173108.3864.57490.stgit@nitbit.x32> (raw)
tc_u32_sel 'sel' in tc_u_knode expects to be the last element in the
structure and pads the structure with tc_u32_key fields for each key.
kzalloc(sizeof(*n) + s->nkeys*sizeof(struct tc_u32_key), GFP_KERNEL)
CC: Eric Dumazet <edumazet@google•com>
Signed-off-by: John Fastabend <john.r.fastabend@intel•com>
---
net/sched/cls_u32.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
index eceeb04..8462132 100644
--- a/net/sched/cls_u32.c
+++ b/net/sched/cls_u32.c
@@ -64,8 +64,9 @@ struct tc_u_knode {
u32 __percpu *pcpu_success;
#endif
struct tcf_proto *tp;
- struct tc_u32_sel sel;
struct rcu_head rcu;
+ struct tc_u32_sel sel;
+ /* tc_u32_keys allocated at end of structure */
};
struct tc_u_hnode {
next reply other threads:[~2014-09-17 17:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 17:31 John Fastabend [this message]
2014-09-17 17:48 ` [net-next PATCH v2] net: sched: cls_u32: rcu can not be last node Eric Dumazet
2014-09-17 18:03 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917173108.3864.57490.stgit@nitbit.x32 \
--to=john.fastabend@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox