Subject: Re: [PATCHv5 net-next 1/3] sunvnet: upgrade to VIO protocol version 1.6

From: Sowmini Varadhan <[email-masked]>
Date: Wed, 17 Sep 2014 18:36:06 -0400

On (09/17/14 16:49), David L Stevens wrote:
> +	/* MTU negotiation:
> +	 *	< v1.3 - ETH_FRAME_LEN exactly
> +	 *	> v1.3 - MIN(pkt.mtu, VNET_MAX_PACKET, port->rmtu) and change
> +	 *			pkt->mtu for ACK
> +	 *	= v1.3 - ETH_FRAME_LEN + VLAN_HLEN exactly
> +	 */

Comment does not match code. Should be VNET_MAXPACKET.

Also, some general questions- 

how does this work for broadcast packets, e.g., if I do 
   "ping -b <broadcast address> -s 60000"

the 65535 MTU is only useful betwen two guests if 
inter-vnet-link is set to on, right? (i.e., can you use it when you 
go from a guest to another IP address on a different physical host)?

--Sowmini