From: Simon Horman <simon.horman@netronome•com>
To: Thomas Graf <tgraf@suug•ch>
Cc: dev@openvswitch•org, netdev@vger•kernel.org,
Pravin Shelar <pshelar@nicira•com>,
Jesse Gross <jesse@nicira•com>
Subject: Re: [PATCH/RFC repost 3/8] odp-util: formatting of datapath select group action
Date: Wed, 24 Sep 2014 13:55:44 +0900 [thread overview]
Message-ID: <20140924045540.GA13314@vergenet.net> (raw)
In-Reply-To: <20140919134449.GA8257@casper.infradead.org>
On Fri, Sep 19, 2014 at 02:44:49PM +0100, Thomas Graf wrote:
> On 09/18/14 at 10:55am, Simon Horman wrote:
> > Allow formatting of select group action. This is used
> > when pretty-printing datapath flows. Subsequent patches
> > will add support for the select group action to the datapath
> > and ovs-vswtichd.
> >
> > Signed-off-by: Simon Horman <simon.horman@netronome•com>
> > ---
> > lib/odp-util.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 67 insertions(+)
> >
> > diff --git a/lib/odp-util.c b/lib/odp-util.c
> > index 77b456f..4c8dd39 100644
> > --- a/lib/odp-util.c
> > +++ b/lib/odp-util.c
> > @@ -182,6 +182,71 @@ format_odp_sample_action(struct ds *ds, const struct nlattr *attr)
> > ds_put_format(ds, "))");
> > }
> >
> > +static bool
> > +format_odp_bucket(struct ds *ds, const struct nlattr *attr)
> > +{
> > + static const struct nl_policy ovs_sample_policy[] = {
>
> Not that it would matter much but you might want to rename that to
> ovs_bucket_policy[]. Same below.
Thanks, I renamed all the new instances of ovs_sample_policy
(which I cut and pasted from the implementation of sample actions).
next prev parent reply other threads:[~2014-09-24 4:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 1:55 [PATCH/RFC repost 0/8] Open vSwtich ODP Select Group Action Simon Horman
2014-09-18 1:55 ` [PATCH/RFC repost 1/8] odp: select group action attributes Simon Horman
2014-09-18 1:55 ` [PATCH/RFC repost 2/8] netlink: Allow suppression of warnings for duplicate attributes Simon Horman
[not found] ` <1411005311-11752-3-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
2014-09-26 23:55 ` Ben Pfaff
2014-10-09 1:18 ` [ovs-dev] " Simon Horman
2014-10-10 15:31 ` Ben Pfaff
2014-09-18 1:55 ` [PATCH/RFC repost 3/8] odp-util: formatting of datapath select group action Simon Horman
[not found] ` <1411005311-11752-4-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
2014-09-19 13:44 ` Thomas Graf
2014-09-24 4:55 ` Simon Horman [this message]
2014-09-18 1:55 ` [PATCH/RFC repost 4/8] datapath: execution of " Simon Horman
[not found] ` <1411005311-11752-5-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
2014-09-19 14:05 ` Thomas Graf
2014-09-24 6:01 ` Simon Horman
2014-09-24 8:19 ` Thomas Graf
2014-09-25 4:43 ` Simon Horman
2014-09-18 1:55 ` [PATCH/RFC repost 5/8] datapath: Move last_action() helper to datapath.h Simon Horman
[not found] ` <1411005311-11752-6-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
2014-09-19 14:06 ` Thomas Graf
2014-09-24 6:00 ` Simon Horman
[not found] ` <20140924060013.GB13314-IxS8c3vjKQDk1uMJSBkQmQ@public.gmane.org>
2014-09-24 8:20 ` Thomas Graf
2014-09-25 4:42 ` Simon Horman
2014-09-18 1:55 ` [PATCH/RFC repost 6/8] datapath: validation of select group action Simon Horman
2014-09-18 1:55 ` [PATCH/RFC repost 7/8] ofproto: translate datapath " Simon Horman
[not found] ` <1411005311-11752-8-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
2014-09-26 23:57 ` Ben Pfaff
2014-10-09 1:14 ` [ovs-dev] " Simon Horman
2014-10-13 20:46 ` Ben Pfaff
2014-10-14 4:54 ` Simon Horman
2014-09-18 1:55 ` [PATCH/RFC repost 8/8] hack: ofproto: enable odp select action Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140924045540.GA13314@vergenet.net \
--to=simon.horman@netronome$(echo .)com \
--cc=dev@openvswitch$(echo .)org \
--cc=jesse@nicira$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pshelar@nicira$(echo .)com \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox