Subject: Re: [net-next PATCH V5] qdisc: bulk dequeue support for qdiscs with TCQ_F_ONETXQUEUE

From: Jesper Dangaard Brouer <[email-masked]>
Date: Wed, 1 Oct 2014 00:07:52 +0200

On Tue, 30 Sep 2014 04:48:56 -0700
Eric Dumazet <[email-masked]> wrote:
 
> In my opinion, you guys missed some opportunities :

This is a conservative first approach.  The merge window is approaching
fast, is is annoying you are blocking a save conservative approach.

> 1) Ideally the algo should try to call validate_xmit_skb() outside of
> the locks (qdisc lock or device lock), because eventually doing checksum
> computation or full segmentation should allow other cpus doing enqueues.

Save it for later please, don't complicate things further.

> 2) TSO support. Have you ideas how to perform this ?

Yes, we already have patches floating which implements bulking of TSO
and GSO packets.  You will get that.

Please one step at a time, also for bisect-ability...

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Sr. Network Kernel Developer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer