Subject: Re: [net-next PATCH] veth: don't assign a qdisc to veth

From: Jesper Dangaard Brouer <[email-masked]>
Date: Fri, 3 Oct 2014 22:38:16 +0200

On Fri, 3 Oct 2014 09:53:16 -0700
Cong Wang <[email-masked]> wrote:

> On Fri, Oct 3, 2014 at 3:48 AM, Jesper Dangaard Brouer
> <[email-masked]> wrote:
> > The veth driver is a virtual device, and should not have assigned
> > the default qdisc.  Verified (ndo_start_xmit) veth_xmit can only
> > return NETDEV_TX_OK, thus this should be safe to bypass qdisc.
> >
> > Not assigning a qdisc is subtly done by setting tx_queue_len to zero.
> >
> 
> Huh?? Maybe your $subject is too misleading, but we do use HTB
> on veth, this will break our code since we will have to set tx_queue_len
> after your patch, no?

No, you HTB setup should still work.

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Sr. Network Kernel Developer at Red Hat
  Author of http://www.iptv-analyzer.org
  LinkedIn: http://www.linkedin.com/in/brouer