Subject: Re: [PATCHv3 RFC net-next 1/4] sunvnet: NAPIfy sunvnet

From: Sowmini Varadhan <[email-masked]>
Date: Wed, 15 Oct 2014 13:22:04 -0400

On (10/15/14 13:17), David L Stevens wrote:
> > -static void maybe_tx_wakeup(unsigned long param)
> > +static void maybe_tx_wakeup(struct vnet *vp)
> >  {
> > -	struct vnet *vp = (struct vnet *)param;
> >  	struct net_device *dev = vp->dev;
> >  
> >  	netif_tx_lock(dev);
> 
> Isn't this a function type conflict for tasklet_init()?

maybe_tx_wakeup is not a tasklet any more. That was one of the
big benefits of going NAPI, as David Miller pointed out- we
are already in NAPI context, so the original reason (deadlock
with dev_watchdog) does not exist any more.

I'm working on adding the rest of your comments about
removing comments and making an int into a bool.

--Sowmini