Subject: Re: bridge: Do not compile options in br_parse_ip_options

From: Florian Westphal <[email-masked]>
Date: Fri, 24 Oct 2014 12:41:49 +0200

Herbert Xu <[email-masked]> wrote:
> bridge: Do not compile options in br_parse_ip_options
> 
> Commit 462fb2af9788a82a534f8184abfde31574e1cfa0
> 
> 	bridge : Sanitize skb before it enters the IP stack
> 
> broke when IP options are actually used because it mangles the
> skb as if it entered the IP stack which is wrong because the
> bridge is supposed to operate below the IP stack.
> 
> Since nobody has actually requested for parsing of IP options
> this patch fixes it by simply reverting to the previous approach
> of ignoring all IP options, i.e., zeroing the IPCB.
> 
> If and when somebody who uses IP options and actually needs them
> to be parsed by the bridge complains then we can revisit this.
> 
> Reported-by: David Newall <[email-masked]>
> Signed-off-by: Herbert Xu <[email-masked]>

Tested-by: Florian Westphal <[email-masked]>

Pablo, could you please apply this?

Thanks!