From: Florian Westphal <fw@strlen•de>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: Florian Westphal <fw@strlen•de>,
David Miller <davem@davemloft•net>,
netdev@vger•kernel.org
Subject: Re: [PATCH -next 0/2] net: allow setting ecn via routing table
Date: Thu, 30 Oct 2014 23:15:01 +0100 [thread overview]
Message-ID: <20141030221501.GA9416@breakpoint.cc> (raw)
In-Reply-To: <1414703260.15352.9.camel@edumazet-glaptop2.roam.corp.google.com>
Eric Dumazet <eric.dumazet@gmail•com> wrote:
> On Thu, 2014-10-30 at 21:52 +0100, Florian Westphal wrote:
>
> > So, what about changing the default to 1 in net-next?
> >
> > We could add automatic 'no-ecn' to retransmitted syns to avoid
> > ecn blackholes (Daniel Borkmann has a patch for this), and, in case
> > ecn=1 causes too much breakage we can always revert (and re-consider ecn
> > per route settings as an intermediate step).
> >
> > What do you think?
>
> I think this is way too dangerous.
>
> I played a lot with ECN in the past (and fixed number of bugs in linux)
> and discovered many times I had to disable it to be able to surf the
> Internet.
[..]
> Reverting might take a long long time, it wont help people stuck behind
> buggy equipment.
Do you think a fallback to non-ecn for retransmitted syns would help?
If not, do you think having ecn tunable available via route is helpful?
Thanks!
next prev parent reply other threads:[~2014-10-30 22:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-25 22:38 [PATCH -next 0/2] net: allow setting ecn via routing table Florian Westphal
2014-10-25 22:38 ` [PATCH -next 1/2] syncookies: remove ecn_ok validation when decoding option timestamp Florian Westphal
2014-10-25 22:38 ` [PATCH -next 2/2] net: allow setting ecn via routing table Florian Westphal
2014-10-28 20:57 ` [PATCH -next 0/2] " David Miller
2014-10-29 12:23 ` Florian Westphal
2014-10-30 19:59 ` David Miller
2014-10-30 20:52 ` Florian Westphal
2014-10-30 21:07 ` Eric Dumazet
2014-10-30 22:15 ` Florian Westphal [this message]
2014-10-30 23:05 ` Eric Dumazet
2014-10-30 23:16 ` Florian Westphal
2014-10-30 23:30 ` Eric Dumazet
2014-10-31 3:49 ` David Miller
2014-10-31 9:24 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141030221501.GA9416@breakpoint.cc \
--to=fw@strlen$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox