Subject: Re: [net-next 1/9] i40e: poll firmware slower

From: Jesse Brandeburg <[email-masked]>
Date: Fri, 7 Nov 2014 15:02:23 -0800

On Fri, 7 Nov 2014 15:29:15 +0200
Or Gerlitz <[email-masked]> wrote:

> On Fri, Nov 7, 2014 at 10:57 AM, Jeff Kirsher
> <[email-masked]> wrote:
> > The code was polling the firmware tail register for completion
> 
> any reason not to sleep while waiting for this completion? can the
> firmware generate an interrupt?

The code path in question is called from the drivers when they are in
a synchronous context and can sleep or be rescheduled without issue.
An async mode is possible, but not here, because the code complexity
required to change to async mode is unmaintainable (if even doable, how
do you handle an interrupt while you're in probe?).  We use async when
it is practical.

Thanks for your comments,
Jesse