public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Alexander Aring <alex.aring@gmail•com>
To: Alexey Khoroshilov <khoroshilov@ispras•ru>
Cc: "David S . Miller" <davem@davemloft•net>,
	linux-wpan@vger•kernel.org, netdev@vger•kernel.org,
	linux-kernel@vger•kernel.org, ldv-project@linuxtesting•org
Subject: Re: [PATCH] ieee802154: fix error handling in ieee802154fake_probe()
Date: Sat, 15 Nov 2014 08:16:06 +0100	[thread overview]
Message-ID: <20141115071603.GA3481@omega> (raw)
In-Reply-To: <1416006719-3450-1-git-send-email-khoroshilov@ispras.ru>

Hi,

On Sat, Nov 15, 2014 at 02:11:59AM +0300, Alexey Khoroshilov wrote:
> In case of any failure ieee802154fake_probe() just calls unregister_netdev().
> But it does not look safe to unregister netdevice before it was registered.
> 
> The patch implements straightforward resource deallocation in case of
> failure in ieee802154fake_probe().
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 

Thanks for the patch! But I already delete the whole fakehard driver.
The patch to remove this driver is already in net-next.

There was too many issues with the fake hardMAC drivers and we don't
really supported a "real" hardMAC transceiver. For my rework to grab the
good things from wireless implementation and put 802.15.4 functionality
on it I simple delete the whole driver and _maybe_ add a new one with
the new introduced interfaces for possible hardMAC functionality.

This patch could go into bluetooth(net)/stable but I don't think that
there are many users for this driver.

- Alex

next prev parent reply	other threads:[~2014-11-15  7:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-14 23:11 [PATCH] ieee802154: fix error handling in ieee802154fake_probe() Alexey Khoroshilov
2014-11-15  7:16 ` Alexander Aring [this message]
2014-11-15  7:58   ` Marcel Holtmann
2014-11-16 19:45     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141115071603.GA3481@omega \
    --to=alex.aring@gmail$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=khoroshilov@ispras$(echo .)ru \
    --cc=ldv-project@linuxtesting$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-wpan@vger$(echo .)kernel.org \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox