From: Greg KH <gregkh@linuxfoundation•org>
To: josh@joshtriplett•org
Cc: "Pieter Smith" <pieter@boesman•nl>,
"Richard Weinberger" <richard.weinberger@gmail•com>,
"Michael S. Tsirkin" <mst@redhat•com>,
"Bertrand Jacquin" <beber@meleeweb•net>,
"Oleg Nesterov" <oleg@redhat•com>,
"J. Bruce Fields" <bfields@fieldses•org>,
"Eric Dumazet" <edumazet@google•com>,
蔡正龙 <zhenglong.cai@cs2c•com.cn>,
"Jeff Layton" <jlayton@poochiereds•net>,
"Tom Herbert" <therbert@google•com>,
"Alexei Starovoitov" <ast@plumgrid•com>,
"Miklos Szeredi" <miklos@szeredi•hu>,
"Peter Foley" <pefoley2@pefoley•com>,
"Hugh Dickins" <hughd@google•com>,
"Xiao Guangrong" <xiaoguangrong@linux•vnet.ibm.com>,
"Geert Uytterhoeven" <geert@linux-m68k•org>,
"Mel Gorman" <mgorman@suse•de>,
"Matt Turner" <mattst88@gmail•com>,
"Paul E. McKenney" <paulmck@linux•vnet.ibm.com>,
"Alexander Duyck" <alexander.h.duyck@intel•com>,
"open list:FUSE: FILESYSTEM..."
<fuse-devel@lists•sourceforge.net>
Subject: Re: [fuse-devel] [PATCH 4/6] fs/fuse: support compiling out splice
Date: Mon, 24 Nov 2014 12:22:14 -0800 [thread overview]
Message-ID: <20141124202214.GA11362@kroah.com> (raw)
In-Reply-To: <20141124201450.GA18776@cloud>
On Mon, Nov 24, 2014 at 12:14:50PM -0800, josh@joshtriplett•org wrote:
> > I would, again, argue that stuff like __splice_p() not be implemented at
> > all please. It will only cause a huge proliferation of stuff like this
> > that will not make any sense, and only cause a trivial, if any, amount
> > of code savings.
> >
> > I thought you were going to not do this type of thing until you got the
> > gcc optimizer working for function callbacks.
>
> Compared to the previous patchset, there are now only two instances of
> ifdefs outside of the splice code for this, and this is one of them. In
> this case, the issue is no longer about making the code for this
> splice_read function disappear, but rather to eliminate a reference to a
> bit of splice functionality (used *inside* the FUSE splice code) that
> will not work without SPLICE_SYSCALL.
>
> Would you prefer to see this specific case handled via an #ifdef in
> fs/fuse/dev.c rather than introducing a __splice_p that people might be
> inclined to propagate? That'd be fine; the code could simply wrap
> fuse_dev_splice_read in an #ifdef and have the #else define a NULL
> fuse_dev_splice_read.
Yes, I would prefer that, but I'm not the fuse maintainer.
thanks,
greg k-h
next prev parent reply other threads:[~2014-11-24 20:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-23 14:20 [PATCH 0/6] kernel tinification: optionally compile out splice family of syscalls (splice, vmsplice, tee and sendfile) Pieter Smith
2014-11-23 14:20 ` [PATCH 2/6] fs: moved kernel_write to fs/read_write Pieter Smith
2014-11-23 14:20 ` [PATCH 3/6] fs/splice: support compiling out splice-family syscalls Pieter Smith
2014-11-23 14:20 ` [PATCH 4/6] fs/fuse: support compiling out splice Pieter Smith
[not found] ` <1416752468-1626-5-git-send-email-pieter-qeJ+1H9vRZbz+pZb47iToQ@public.gmane.org>
2014-11-23 22:29 ` [fuse-devel] " Richard Weinberger
2014-11-23 23:23 ` Josh Triplett
2014-11-24 9:49 ` Pieter Smith
2014-11-24 16:05 ` Josh Triplett
2014-11-24 19:34 ` Greg KH
[not found] ` <20141124193412.GB31618-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2014-11-24 20:14 ` josh-iaAMLnmF4UmaiuxdJuQwMA
2014-11-24 20:22 ` Greg KH [this message]
[not found] ` <20141124202214.GA11362-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2014-11-24 21:49 ` Pieter Smith
[not found] ` <1416752468-1626-1-git-send-email-pieter-qeJ+1H9vRZbz+pZb47iToQ@public.gmane.org>
2014-11-23 14:20 ` [PATCH 1/6] fs: move sendfile syscall into fs/splice Pieter Smith
2014-11-23 14:20 ` [PATCH 5/6] net/core: support compiling out splice Pieter Smith
2014-11-23 14:20 ` [PATCH 6/6] fs/splice: full support for " Pieter Smith
2014-11-23 18:46 ` [PATCH 0/6] kernel tinification: optionally compile out splice family of syscalls (splice, vmsplice, tee and sendfile) David Miller
[not found] ` <20141123.134623.2061031332250984539.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-11-23 19:43 ` Josh Triplett
2014-11-23 20:30 ` Pieter Smith
2014-11-23 23:36 ` Josh Triplett
2014-11-24 0:28 ` Jeff Layton
[not found] ` <20141123192810.682a223e-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2014-11-24 0:32 ` Josh Triplett
2014-11-24 10:01 ` Pieter Smith
2014-11-24 14:54 ` Josh Triplett
2014-11-24 8:38 ` Geert Uytterhoeven
[not found] ` <CAMuHMdW8gAiyFiPHu-N4Dg_+b6Qg9JXZZ3PqOn=VmZLcEH-Xkg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-24 9:00 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141124202214.GA11362@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=alexander.h.duyck@intel$(echo .)com \
--cc=ast@plumgrid$(echo .)com \
--cc=beber@meleeweb$(echo .)net \
--cc=bfields@fieldses$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=fuse-devel@lists$(echo .)sourceforge.net \
--cc=geert@linux-m68k$(echo .)org \
--cc=hughd@google$(echo .)com \
--cc=jlayton@poochiereds$(echo .)net \
--cc=josh@joshtriplett$(echo .)org \
--cc=mattst88@gmail$(echo .)com \
--cc=mgorman@suse$(echo .)de \
--cc=miklos@szeredi$(echo .)hu \
--cc=mst@redhat$(echo .)com \
--cc=oleg@redhat$(echo .)com \
--cc=paulmck@linux$(echo .)vnet.ibm.com \
--cc=pefoley2@pefoley$(echo .)com \
--cc=pieter@boesman$(echo .)nl \
--cc=richard.weinberger@gmail$(echo .)com \
--cc=therbert@google$(echo .)com \
--cc=xiaoguangrong@linux$(echo .)vnet.ibm.com \
--cc=zhenglong.cai@cs2c$(echo .)com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox