Subject: Re: [net] gre: fix the inner mac header in nbma gre tunnels xmit path

From: Timo Teras <[email-masked]>
Date: Thu, 11 Dec 2014 21:44:56 +0200

On Thu, 11 Dec 2014 14:36:27 -0500 (EST)
David Miller <[email-masked]> wrote:

> From: Timo Teräs <[email-masked]>
> Date: Thu, 11 Dec 2014 09:14:39 +0200
> 
> > @@ -266,6 +262,7 @@ static netdev_tx_t ipgre_xmit(struct sk_buff
> > *skb,
> >  		 * to gre header.
> >  		 */
> >  		skb_pull(skb, tunnel->hlen + sizeof(struct iphdr));
> > +		skb_reset_mac_header(mac);
> 
> Please explain to me how this compiles, let alone be functionally
> tested.

Sorry. I made the change twice; once on the build box. And again on my
git checkout on work station. Must've been on seriously coffee deprived
state.

Should be obviously:
+		skb_reset_mac_header(skb);

Is there other comments on it?

Or shall I resend?