Subject: Re: [PATCH net-next v3] Add support of Cavium Liquidio ethernet adapters

From: Stephen Hemminger <[email-masked]>
Date: Thu, 18 Dec 2014 23:03:51 -0800

On Thu, 18 Dec 2014 19:25:19 -0800
Raghu Vatsavayi <[email-masked]> wrote:

> +	if (linfo->link.s.status) {
> +		ecmd->speed = linfo->link.s.speed;
> +		ecmd->duplex = linfo->link.s.duplex;
> +	} else {
> +		ecmd->speed = -1;
> +		ecmd->duplex = -1;
> +	}
> +

You should SPEED_UNKNOWN and DUPLEX_UNKNOWN (not -1).
and don't set ecmd->speed directly, use
     ethtool_cmd_speed_sed(ecmd, speed)