public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail•com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel•com>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
	Amir Vadai <amirv@mellanox•com>,
	Ariel Elior <ariel.elior@qlogic•com>,
	Carolyn Wyborny <carolyn.wyborny@intel•com>,
	David Miller <davem@davemloft•net>,
	Frank Li <Frank.Li@freescale•com>,
	John Stultz <john.stultz@linaro•org>,
	Matthew Vick <matthew.vick@intel•com>,
	Miroslav Lichvar <mlichvar@redhat•com>,
	Mugunthan V N <mugunthanvnm@ti•com>,
	Or Gerlitz <ogerlitz@mellanox•com>,
	Thomas Gleixner <tglx@linutronix•de>,
	Tom Lendacky <thomas.lendacky@amd•com>
Subject: Re: [PATCH net-next 08/11] net: ixgbe: convert to timecounter adjtime.
Date: Tue, 23 Dec 2014 22:42:53 +0100	[thread overview]
Message-ID: <20141223214253.GA13937@localhost.localdomain> (raw)
In-Reply-To: <1419368839.2470.32.camel@jtkirshe-mobl>

On Tue, Dec 23, 2014 at 01:07:19PM -0800, Jeff Kirsher wrote:
> Just for sanity sake, I will have Phillip test the changes, but there is
> no need to hold this up from being committed in the mean time.

FYI, here is a test that may show the improved behavior when comparing
before/after.

1. Start ptp4l, let it run long enough to find the frequency offset.

2. Stop ptp4l with ^C.

3. Wait a bit, to let the clock drift away.

4. Restart ptp4l, it will now start with the frequency offset learned
   in step 1.

5. Notice the the offsets in states s0 -> s1 -> s2.
   There will likely be less offset error with the patches applied.

Thanks,
Richard

  reply	other threads:[~2014-12-23 21:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-21 18:46 [PATCH net-next 00/11] Time Counter fixes and improvements Richard Cochran
2014-12-21 18:46 ` [PATCH net-next 01/11] time: move the timecounter/cyclecounter code into its own file Richard Cochran
2014-12-23 21:03   ` Jeff Kirsher
2014-12-21 18:46 ` [PATCH net-next 02/11] timecounter: provide a helper function to shift the time Richard Cochran
2014-12-21 18:46 ` [PATCH net-next 03/11] net: xgbe: convert to timecounter adjtime Richard Cochran
2014-12-21 18:46 ` [PATCH net-next 04/11] net: bnx2x: " Richard Cochran
2014-12-21 19:01   ` Richard Cochran
2014-12-21 18:47 ` [PATCH net-next 05/11] net: fec: " Richard Cochran
2014-12-21 18:47 ` [PATCH net-next 06/11] net: e1000e: " Richard Cochran
2014-12-23 21:04   ` Jeff Kirsher
2014-12-21 18:47 ` [PATCH net-next 07/11] net: igb: " Richard Cochran
2014-12-23 21:04   ` Jeff Kirsher
2014-12-21 18:47 ` [PATCH net-next 08/11] net: ixgbe: " Richard Cochran
2014-12-23 21:07   ` Jeff Kirsher
2014-12-23 21:42     ` Richard Cochran [this message]
2014-12-21 18:47 ` [PATCH net-next 09/11] net: mlx4: " Richard Cochran
2014-12-21 18:47 ` [PATCH net-next 10/11] net: cpts: " Richard Cochran
2014-12-21 18:47 ` [PATCH net-next 11/11] timecounter: keep track of accumulated fractional nanoseconds Richard Cochran
2014-12-30 23:32 ` [PATCH net-next 00/11] Time Counter fixes and improvements David Miller
2014-12-31 17:42   ` Richard Cochran
2015-01-02 18:37 ` John Stultz
2015-01-02 18:49   ` Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141223214253.GA13937@localhost.localdomain \
    --to=richardcochran@gmail$(echo .)com \
    --cc=Frank.Li@freescale$(echo .)com \
    --cc=amirv@mellanox$(echo .)com \
    --cc=ariel.elior@qlogic$(echo .)com \
    --cc=carolyn.wyborny@intel$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=jeffrey.t.kirsher@intel$(echo .)com \
    --cc=john.stultz@linaro$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=matthew.vick@intel$(echo .)com \
    --cc=mlichvar@redhat$(echo .)com \
    --cc=mugunthanvnm@ti$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=ogerlitz@mellanox$(echo .)com \
    --cc=tglx@linutronix$(echo .)de \
    --cc=thomas.lendacky@amd$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox