Subject: Re: [PATCH iproute2 v3] tc: Show classes in tree view

From: Stephen Hemminger <[email-masked]>
Date: Wed, 24 Dec 2014 12:42:56 -0800

On Wed, 24 Dec 2014 02:46:16 +0200
Vadim Kochan <[email-masked]> wrote:

> From: Vadim Kochan <[email-masked]>
> 
> Added new '-t[ree]' which shows classes dependency
> in the tree view. Meanwhile only generic stats info
> is supported.
> 

I don't get strict about checkpatch. But ran this patch through and there are some minor
things that would be good to fix.
  1. Split long lines like:
WARNING: line over 80 characters
#198: FILE: tc/tc_class.c:219:
+static void tree_cls_show(FILE *fp, char *buf, struct hlist_head *root_list, int level)

  2. Don't use variable name 'childs', makes sense to call it children instead??

  3. Don't use space before * as in:
ERROR: "foo * bar" should be "foo *bar"
#285: FILE: tc/tc_class.c:305:
+	struct rtattr * tb[TCA_MAX+1] = {};