Subject: Re: [PATCH] can: kvaser_usb: Don't free packets when tight on URBs

From: Stephen Hemminger <[email-masked]>
Date: Thu, 1 Jan 2015 13:59:13 -0800

On Tue, 23 Dec 2014 17:46:54 +0200
"Ahmed S. Darwish" <[email-masked]> wrote:

>  	int ret = NETDEV_TX_OK;
> +	bool kfree_skb_on_error = true;
>  
>  	if (can_dropped_invalid_skb(netdev, skb))
>  		return NETDEV_TX_OK;
> @@ -1336,6 +1337,7 @@ static netdev_tx_t kvaser_usb_start_xmit(struct sk_buff *skb,
>  
>  	if (!context) {
>  		netdev_warn(netdev, "cannot find free context\n");
> +		kfree_skb_on_error = false;
>  		ret =  NETDEV_TX_BUSY;

You already have a flag value (ret == NETDEV_TX_BUSY), why
not use that instead of introducing another variable?