From: Asaf Vertz <asaf.vertz@tandemg•com>
To: jeffrey.t.kirsher@intel•com
Cc: jesse.brandeburg@intel•com, bruce.w.allan@intel•com,
carolyn.wyborny@intel•com, donald.c.skidmore@intel•com,
gregory.v.rose@intel•com, matthew.vick@intel•com,
john.ronciak@intel•com, mitch.a.williams@intel•com,
linux.nics@intel•com, e1000-devel@lists•sourceforge.net,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: [PATCH] e1000: fix time comparison
Date: Wed, 7 Jan 2015 14:41:45 +0200 [thread overview]
Message-ID: <20150107124145.GA15954@ubuntu> (raw)
To be future-proof and for better readability the time comparisons are
modified to use time_after_eq() instead of plain, error-prone math.
Signed-off-by: Asaf Vertz <asaf.vertz@tandemg•com>
---
drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c
index b691eb4..4270ad2 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c
+++ b/drivers/net/ethernet/intel/e1000/e1000_ethtool.c
@@ -24,6 +24,7 @@
/* ethtool support for e1000 */
#include "e1000.h"
+#include <linux/jiffies.h>
#include <linux/uaccess.h>
enum {NETDEV_STATS, E1000_STATS};
@@ -1460,7 +1461,7 @@ static int e1000_run_loopback_test(struct e1000_adapter *adapter)
ret_val = 13; /* ret_val is the same as mis-compare */
break;
}
- if (jiffies >= (time + 2)) {
+ if (time_after_eq(jiffies, time + 2)) {
ret_val = 14; /* error code for time out error */
break;
}
--
1.7.0.4
next reply other threads:[~2015-01-07 12:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 12:41 Asaf Vertz [this message]
2015-01-07 22:02 ` [linux-nics] [PATCH] e1000: fix time comparison Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150107124145.GA15954@ubuntu \
--to=asaf.vertz@tandemg$(echo .)com \
--cc=bruce.w.allan@intel$(echo .)com \
--cc=carolyn.wyborny@intel$(echo .)com \
--cc=donald.c.skidmore@intel$(echo .)com \
--cc=e1000-devel@lists$(echo .)sourceforge.net \
--cc=gregory.v.rose@intel$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=john.ronciak@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux.nics@intel$(echo .)com \
--cc=matthew.vick@intel$(echo .)com \
--cc=mitch.a.williams@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox