From: Dan Carpenter <dan.carpenter@oracle•com>
To: maheshb@google•com
Cc: netdev@vger•kernel.org
Subject: re: ipvlan: Initial check-in of the IPVLAN driver.
Date: Mon, 19 Jan 2015 17:40:11 +0300 [thread overview]
Message-ID: <20150119144011.GA19086@mwanda> (raw)
Hello Mahesh Bandewar,
The patch 2ad7bf363841: "ipvlan: Initial check-in of the IPVLAN
driver." from Nov 23, 2014, leads to the following static checker
warning:
drivers/net/ipvlan/ipvlan_core.c:380 ipvlan_process_v6_outbound()
warn: 'dst' isn't an ERR_PTR
drivers/net/ipvlan/ipvlan_core.c
378
379 dst = ip6_route_output(dev_net(dev), NULL, &fl6);
380 if (IS_ERR(dst))
381 goto err;
The ip6_route_output() function is not documented but it always returns
a valid pointer. I believe you are supposed to check something like:
if (dst->error) {
ret = dst->error;
goto error;
}
382
383 skb_dst_drop(skb);
384 skb_dst_set(skb, dst);
regards,
dan carpenter
next reply other threads:[~2015-01-19 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 14:40 Dan Carpenter [this message]
2015-01-19 21:20 ` ipvlan: Initial check-in of the IPVLAN driver David Miller
2015-01-23 22:40 ` Mahesh Bandewar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150119144011.GA19086@mwanda \
--to=dan.carpenter@oracle$(echo .)com \
--cc=maheshb@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox