public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Kumar Sanghvi <kumaras@chelsio•com>
To: Eric Dumazet <eric.dumazet@gmail•com>
Cc: Hariprasad Shenai <hariprasad@chelsio•com>,
	<netdev@vger•kernel.org>, <davem@davemloft•net>,
	<leedom@chelsio•com>, <anish@chelsio•com>,
	<nirranjan@chelsio•com>, <praveenm@chelsio•com>
Subject: Re: [PATCH net-next] cxgb4: Add low latency socket busy_poll support
Date: Wed, 4 Feb 2015 12:21:39 +0600	[thread overview]
Message-ID: <20150204062137.GD30631@kumar-pc.asicdesigners.com> (raw)
In-Reply-To: <1423029509.907.79.camel@edumazet-glaptop2.roam.corp.google.com>

On Tuesday, February 02/03/15, 2015 at 21:58:29 -0800, Eric Dumazet wrote:
> On Tue, 2015-02-03 at 10:50 +0530, Hariprasad Shenai wrote:
> 
> > @@ -1978,9 +2016,13 @@ static int napi_rx_handler(struct napi_struct *napi, int budget)
> >  {
> >  	unsigned int params;
> >  	struct sge_rspq *q = container_of(napi, struct sge_rspq, napi);
> > -	int work_done = process_responses(q, budget);
> > +	int work_done = 0;
> >  	u32 val;
> >  
> > +	if (!cxgb_poll_lock_napi(q))
> > +		return work_done;
> > +
> 
> 
> This is very suspicious. Please take a look at commits
> 
> 24e579c8898aa641 ("bnx2x: fix napi poll return value for repoll") 
> f104fedc0da126ab ("enic: fix rx napi poll return value")
> 
> for context.

Thanks Eric for pointing on this.
So, this probably needs change after commit d75b1ade567ffab ("net: less interrupt masking in NAPI"), or
is there something else that is missed ?


Thanks,
Kumar.

next prev parent reply	other threads:[~2015-02-04  6:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-03  5:20 [PATCH net-next] cxgb4: Add low latency socket busy_poll support Hariprasad Shenai
2015-02-03 16:45 ` Rick Jones
2015-02-04  6:24   ` Kumar Sanghvi
2015-02-04  5:58 ` Eric Dumazet
2015-02-04  6:21   ` Kumar Sanghvi [this message]
2015-02-04  7:50     ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150204062137.GD30631@kumar-pc.asicdesigners.com \
    --to=kumaras@chelsio$(echo .)com \
    --cc=anish@chelsio$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=eric.dumazet@gmail$(echo .)com \
    --cc=hariprasad@chelsio$(echo .)com \
    --cc=leedom@chelsio$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=nirranjan@chelsio$(echo .)com \
    --cc=praveenm@chelsio$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox