Subject: Re: [PATCH iproute2] bridge: Show state names in the 'link help' print

From: Vadim Kochan <[email-masked]>
Date: Thu, 26 Feb 2015 03:03:50 +0200

On Wed, Feb 25, 2015 at 05:09:50PM -0800, Stephen Hemminger wrote:
> On Thu, 26 Feb 2015 01:56:33 +0200
> Vadim Kochan <[email-masked]> wrote:
> 
> > From: Vadim Kochan <[email-masked]>
> > 
> > Signed-off-by: Vadim Kochan <[email-masked]>
> > ---
> >  bridge/link.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/bridge/link.c b/bridge/link.c
> > index a7bd85f..7f1ec70 100644
> > --- a/bridge/link.c
> > +++ b/bridge/link.c
> > @@ -228,6 +228,12 @@ static void usage(void)
> >  	fprintf(stderr,	"                               [ flood {on | off} ]\n");
> >  	fprintf(stderr, "                               [ hwmode {vepa | veb} ]\n");
> >  	fprintf(stderr, "       bridge link show [dev DEV]\n");
> > +	fprintf(stderr, "\n");
> > +	fprintf(stderr, "STATE := { 0 | disabled   |\n");
> > +	fprintf(stderr, "           1 | listening  |\n");
> > +	fprintf(stderr, "           2 | learning   |\n");
> > +	fprintf(stderr, "           3 | forwarding |\n");
> > +	fprintf(stderr, "           4 | blocking }\n");
> >  	exit(-1);
> >  }
> >  
> 
> that is too wordy for help. put it in docs if needed.

Hm, I assumed this might be useful for fast looking for state names from the shell just by 'link help'...