From: Andrew Lunn <andrew@lunn•ch>
To: Florian Fainelli <f.fainelli@gmail•com>
Cc: Jonas Johansson <jonasj76@gmail•com>,
netdev@vger•kernel.org,
Jonas Johansson <jonas.johansson@westermo•se>,
Jiri Pirko <jiri@resnulli•us>, Scott Feldman <sfeldma@gmail•com>
Subject: Re: [PATCH net-next 2/2] mv88e6131: bonding: implement single device trunking
Date: Fri, 6 Mar 2015 22:47:23 +0100 [thread overview]
Message-ID: <20150306214723.GB582@lunn.ch> (raw)
In-Reply-To: <54FA125E.6050605@gmail.com>
Hi Florian
> Most Broadcom switches, either SF2 or roboswitch (b53) have a limit of 2
> trunking groups, without limitations on the number of ports included in
> any of these two groups.
O.K, so maybe we want the basic resource management in the DSA layer,
not the switch drivers.
> The larger question is once we start advertising capabilities, where
> does that stop, right? It would probably be simpler for now to e.g:
> allow 2 trunking groups to be configured, and when trying to configure a
> 3rd one, return -ENOSPC and act upon that to either take the software
> slow path (which is probably not possible) or just return a hard error
> condition.
This is more than a DSA question. It applies to all the hardware
acceleration being discussed at the moment. As you hinted to above, i
suppose we have two different situations:
1) We can fall back to a software slow path.
2) There is no software fallback, we have to error out, and it would
be nice to have a well defined error code for out of hardware
resources.
We also should think about how we tell user space we have fallen back
to a slow path. I'm sure users want to know why it works, but works
much slower.
Andrew
next prev parent reply other threads:[~2015-03-06 21:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 10:51 [PATCH net-next 0/2] dsa: implement HW bonding Jonas Johansson
2015-02-20 10:51 ` [PATCH net-next 1/2] dsa: bonding: " Jonas Johansson
2015-02-20 15:12 ` Andrew Lunn
2015-02-20 16:19 ` Jonas Johansson
2015-02-20 16:41 ` Florian Fainelli
2015-02-20 17:56 ` roopa
2015-02-20 19:28 ` Jonas Johansson
2015-02-21 16:57 ` Jiri Pirko
2015-02-21 20:43 ` Andrew Lunn
2015-02-21 21:12 ` Scott Feldman
2015-02-23 15:52 ` Jonas Johansson
2015-02-20 10:51 ` [PATCH net-next 2/2] mv88e6131: bonding: implement single device trunking Jonas Johansson
2015-02-20 15:26 ` Andrew Lunn
2015-02-20 15:56 ` Jonas Johansson
2015-03-06 17:06 ` Florian Fainelli
2015-03-06 19:23 ` Andrew Lunn
2015-03-06 20:47 ` Florian Fainelli
2015-03-06 21:47 ` Andrew Lunn [this message]
2015-03-06 22:43 ` Scott Feldman
2015-03-07 14:38 ` Jiri Pirko
2015-03-07 17:31 ` John Fastabend
2015-02-21 16:40 ` [PATCH net-next 0/2] dsa: implement HW bonding Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150306214723.GB582@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=f.fainelli@gmail$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=jonas.johansson@westermo$(echo .)se \
--cc=jonasj76@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sfeldma@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox