From: Greg KH <gregkh@linuxfoundation•org>
To: Or Gerlitz <ogerlitz@mellanox•com>
Cc: Hadar Hen Zion <hadarh@dev•mellanox.co.il>,
David Miller <davem@davemloft•net>,
Amir Vadai <amirv@mellanox•com>, netdev <netdev@vger•kernel.org>,
Hadar Hen Zion <hadarh@mellanox•com>,
yevgenyp@mellanox•com, Tal Alon <talal@mellanox•com>,
shannon.nelson@intel•com, dledford@redhat•com,
greearb@candelatech•com, gregory.v.rose@intel•com,
jeffrey.t.kirsher@intel•com, jesse.brandeburg@intel•com,
john.ronciak@intel•com
Subject: Re: [PATCH net-next V1 0/3] net/mlx4_core: Allow setting init-time device specific parameters
Date: Thu, 12 Mar 2015 14:46:51 +0100 [thread overview]
Message-ID: <20150312134651.GB32053@kroah.com> (raw)
In-Reply-To: <5501803D.8020101@mellanox.com>
On Thu, Mar 12, 2015 at 02:02:05PM +0200, Or Gerlitz wrote:
> On 3/12/2015 11:00 AM, Greg KH wrote:
> >On Thu, Mar 12, 2015 at 10:07:35AM +0200, Hadar Hen Zion wrote:
> >>On Wed, Mar 11, 2015 at 7:14 PM, David Miller <davem@davemloft•net> wrote:
> >>>From: Amir Vadai <amirv@mellanox•com>
> >>>Date: Wed, 11 Mar 2015 11:08:50 +0200
> >>>
> >>>>Also, customers are paying for a very sophisticated piece of hardware, and we would like to enable power user to tweak it in some situtations. Of course the default mode should be used in 99% of the use cases.
> >>>How much money someone pays for your hardware has nothing to do with the standards by which we design userspace interfaces to configure these devices.
> >>>
> >>>These textual interfaces are arbitrary, and you are choosing it only because you cannot come up with a more reasonable scheme,
> >>>
> >>>I'm not applying these changes.
> >>>---
> >>In previous conversations Greg suggested us to use configfs.
> >>
> >>Is this case a misuse of configfs? maybe configfs should be deprecated... Greg?
> >No, this has nothing to do with the validity of configfs, please re-read what David said to you.
>
> Greg,
>
> So.. M2-- reading Dave's words I understand that he's against textual
> interfacessuch as configfs and prefers others. This brings two questions to
> the table (1) do we need to deprecate these textual interfaces / configfs
> and avoid using them for configuration purposes with new code?
No, configfs works quite well for a number of other kernel subsystems,
so please leave them alone here.
> (2) does
> programmable interface such as netlink is the way to go for our purposes
> here (and elsewhere)?
I don't know, that's up to the network developers, but you had better
not abuse the firmware download inteface, that's what I strongly
objected to originally.
good luck,
greg k-h
next prev parent reply other threads:[~2015-03-12 13:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 9:08 [PATCH net-next V1 0/3] net/mlx4_core: Allow setting init-time device specific parameters Amir Vadai
2015-03-11 9:08 ` [PATCH net-next V1 1/3] net/mlx4_core: Add configfs entries for setting " Amir Vadai
2015-03-11 9:08 ` [PATCH net-next V1 2/3] net/mlx4_core: Set port_type value according to configfs configuration Amir Vadai
2015-03-11 9:08 ` [PATCH net-next V1 3/3] net/mlx4_core: Set DMFS mode " Amir Vadai
2015-03-11 17:14 ` [PATCH net-next V1 0/3] net/mlx4_core: Allow setting init-time device specific parameters David Miller
2015-03-12 8:07 ` Hadar Hen Zion
2015-03-12 9:00 ` Greg KH
2015-03-12 12:02 ` Or Gerlitz
2015-03-12 13:46 ` Greg KH [this message]
2015-03-12 18:09 ` David Miller
2015-03-12 18:05 ` David Miller
2015-03-12 18:59 ` Hadar Hen Zion
2015-03-12 19:31 ` David Miller
2015-03-12 20:51 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150312134651.GB32053@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=amirv@mellanox$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dledford@redhat$(echo .)com \
--cc=greearb@candelatech$(echo .)com \
--cc=gregory.v.rose@intel$(echo .)com \
--cc=hadarh@dev$(echo .)mellanox.co.il \
--cc=hadarh@mellanox$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=john.ronciak@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ogerlitz@mellanox$(echo .)com \
--cc=shannon.nelson@intel$(echo .)com \
--cc=talal@mellanox$(echo .)com \
--cc=yevgenyp@mellanox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox