From: Vadim Kochan <vadim4j@gmail•com>
To: Cong Wang <cwang@twopensource•com>
Cc: "Соловьев Сергей" <sol@eqv•ru>, netdev <netdev@vger•kernel.org>
Subject: Re: Possible bug in tc tool or kernel
Date: Tue, 17 Mar 2015 23:21:32 +0200 [thread overview]
Message-ID: <20150317212132.GA1108@angus-think.lan> (raw)
In-Reply-To: <CAHA+R7O__y1_czX74Ga1RSU-x8X0hUhs2Z01=vo37QUVkNniKQ@mail.gmail.com>
On Tue, Mar 17, 2015 at 01:42:54PM -0700, Cong Wang wrote:
> On Tue, Mar 17, 2015 at 2:57 AM, Соловьев Сергей <sol@eqv•ru> wrote:
> > Hi!
> >
> > I'm sol sorry, but English in not my native language.
> >
> > After upgrade kernel tc lost some u32 filters
> >
> > example: where is a "match ip dst 10.10.0.0/24" entries?
> >
>
> Can you check if the following commit fixes your problem?
>
> It is already merged in stable kernel, you probably need to
> wait for a newer Fedora kernel release if it has included it.
>
> commit b057df24a7536cce6c372efe9d0e3d1558afedf4
> Author: Ignacy Gawędzki <ignacy.gawedzki@green-communications•fr>
> Date: Tue Feb 3 19:05:18 2015 +0100
>
> cls_api.c: Fix dumping of non-existing actions' stats.
>
> In tcf_exts_dump_stats(), ensure that exts->actions is not empty before
> accessing the first element of that list and calling tcf_action_copy_stats()
> on it. This fixes some random segvs when adding filters of type
> "basic" with
> no particular action.
>
> This also fixes the dumping of those "no-action" filters, which more often
> than not made calls to tcf_action_copy_stats() fail and consequently netlink
> attributes added by the caller to be removed by a call to nla_nest_cancel().
>
> Fixes: 33be62715991 ("net_sched: act: use standard struct list_head")
> Signed-off-by: Ignacy Gawędzki <ignacy.gawedzki@green-communications•fr>
> Acked-by: Cong Wang <cwang@twopensource•com>
> Signed-off-by: David S. Miller <davem@davemloft•net>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger•kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
I tested on:
Linux 4.0.0-rc3-ARCH-00130-g4363890 #1 SMP PREEMPT Tue Mar 17 23:11:06 EET 2015 x86_64 GNU/Linux
and got this:
$ tc filter list dev lo
filter parent 1: protocol ip pref 10 u32
filter parent 1: protocol ip pref 10 u32 fh 209: ht divisor 256
filter parent 1: protocol ip pref 10 u32 fh 208: ht divisor 256
filter parent 1: protocol ip pref 10 u32 fh 207: ht divisor 256
filter parent 1: protocol ip pref 10 u32 fh 206: ht divisor 256
filter parent 1: protocol ip pref 10 u32 fh 205: ht divisor 256
filter parent 1: protocol ip pref 10 u32 fh 204: ht divisor 256
filter parent 1: protocol ip pref 10 u32 fh 203: ht divisor 256
filter parent 1: protocol ip pref 10 u32 fh 202: ht divisor 256
filter parent 1: protocol ip pref 10 u32 fh 201: ht divisor 256
filter parent 1: protocol ip pref 10 u32 fh 200: ht divisor 256
filter parent 1: protocol ip pref 10 u32 fh 100: ht divisor 256
filter parent 1: protocol ip pref 10 u32 fh 100::800 order 2048 key ht 100 bkt 0 link 200:
match 0a0a0000/ffffff00 at 16
hash mask 000000ff at 16
filter parent 1: protocol ip pref 10 u32 fh 100:1:800 order 2048 key ht 100 bkt 1 link 201:
match 0a0a0100/ffffff00 at 16
hash mask 000000ff at 16
filter parent 1: protocol ip pref 10 u32 fh 100:2:800 order 2048 key ht 100 bkt 2 link 202:
match 0a0a0200/ffffff00 at 16
hash mask 000000ff at 16
filter parent 1: protocol ip pref 10 u32 fh 100:3:800 order 2048 key ht 100 bkt 3 link 203:
match 0a0a0300/ffffff00 at 16
hash mask 000000ff at 16
filter parent 1: protocol ip pref 10 u32 fh 100:4:800 order 2048 key ht 100 bkt 4 link 204:
match 0a0a0400/ffffff00 at 16
hash mask 000000ff at 16
filter parent 1: protocol ip pref 10 u32 fh 100:5:800 order 2048 key ht 100 bkt 5 link 205:
match 0a0a0500/ffffff00 at 16
hash mask 000000ff at 16
filter parent 1: protocol ip pref 10 u32 fh 100:6:800 order 2048 key ht 100 bkt 6 link 206:
match 0a0a0600/ffffff00 at 16
hash mask 000000ff at 16
filter parent 1: protocol ip pref 10 u32 fh 100:7:800 order 2048 key ht 100 bkt 7 link 207:
match 0a0a0700/ffffff00 at 16
hash mask 000000ff at 16
filter parent 1: protocol ip pref 10 u32 fh 100:8:800 order 2048 key ht 100 bkt 8 link 208:
match 0a0a0800/ffffff00 at 16
hash mask 000000ff at 16
filter parent 1: protocol ip pref 10 u32 fh 100:9:800 order 2048 key ht 100 bkt 9 link 209:
match 0a0a0900/ffffff00 at 16
hash mask 000000ff at 16
filter parent 1: protocol ip pref 10 u32 fh 800: ht divisor 1
filter parent 1: protocol ip pref 10 u32 fh 800::800 order 2048 key ht 800 bkt 0 link 100:
match 0a0a0000/ffff0000 at 16
hash mask 0000ff00 at 16
Regards,
next prev parent reply other threads:[~2015-03-17 21:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 9:57 Possible bug in tc tool or kernel Соловьев Сергей
2015-03-17 20:42 ` Cong Wang
2015-03-17 21:21 ` Vadim Kochan [this message]
2015-03-19 14:45 ` Соловьев Сергей
2015-03-19 17:40 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317212132.GA1108@angus-think.lan \
--to=vadim4j@gmail$(echo .)com \
--cc=cwang@twopensource$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sol@eqv$(echo .)ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox