From: Alexey Dobriyan <adobriyan@gmail•com>
To: Jay Vosburgh <jay.vosburgh@canonical•com>
Cc: davem@davemloft•net, vfalico@gmail•com, andy@greyhouse•net,
netdev@vger•kernel.org
Subject: Re: [PATCH] bonding: ban stacked bonding support
Date: Fri, 20 Mar 2015 20:43:09 +0300 [thread overview]
Message-ID: <20150320174308.GA2005@p183.telecom.by> (raw)
In-Reply-To: <22754.1424474040@famine>
On Fri, Feb 20, 2015 at 03:14:00PM -0800, Jay Vosburgh wrote:
> Instead of a separate block for IFF_MASTER, the IFF_SLAVE line
> could be replaced with something like:
>
> if (netif_is_bond_slave(slave_dev) || netif_is_bond_master(slave_dev)) {
> netdev_dbg(bond_dev, "Error: Device is bond slave or master\n");
I think separate error messages are better (kernel can distinguish between
two anyway).
next prev parent reply other threads:[~2015-03-20 17:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 22:20 [PATCH] bonding: ban stacked bonding support Alexey Dobriyan
2015-02-20 23:14 ` Jay Vosburgh
2015-02-21 2:55 ` Andy Gospodarek
2015-02-21 16:59 ` Jiri Pirko
2015-03-20 17:43 ` Alexey Dobriyan [this message]
2015-03-20 17:46 ` [PATCH v2] " Alexey Dobriyan
2015-03-20 20:38 ` David Miller
2015-03-20 21:02 ` Jay Vosburgh
2015-03-20 22:30 ` Jay Vosburgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320174308.GA2005@p183.telecom.by \
--to=adobriyan@gmail$(echo .)com \
--cc=andy@greyhouse$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=jay.vosburgh@canonical$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vfalico@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox