public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Vadim Kochan <vadim4j@gmail•com>
To: Joe Harvell <jharvell@dogpad•tk>
Cc: netdev@vger•kernel.org, Stephen Hemminger <shemming@brocade•com>
Subject: Re: contributions to iproute2
Date: Sat, 21 Mar 2015 08:25:37 +0200	[thread overview]
Message-ID: <20150321062537.GA23505@angus-think.lan> (raw)
In-Reply-To: <550CF00C.2090309@dogpad.tk>

On Fri, Mar 20, 2015 at 11:14:04PM -0500, Joe Harvell wrote:
> Thanks, Stephen.
> 
> The bugfix is attached as fix-broken-get_prefix_1.diff with the following
> commit log:
> 
> commit 415464c94a62cfaa9c5ba493e45ce24a58d2118a
> Author: Joe Harvell <joe.harvell@tekcomms•com>
> Date:   Fri Mar 20 15:08:51 2015 -0500
> 
>      Fixing obvious error of passing in the wrong variable for the family
> parameter
>      of af_bit_len.
> 
> I assume master must have some new change because this fix was needed for a
> basic 'ip addr add 10.0.3.1/24 dev dumbo label foo' command I pased in.  In
> this case, 'family' passed into get_addr_1 two lines above is zero, causing
> get_addr_1 to detect the family from the address and populate the result in
> the family field in dst.  But then instead of passing in the result, family
> (still 0) is passed in to af_bit_len. Without my change, the above command
> complains that 10.0.3.1/24 is not an address prefix.  With the change it
> works fine as expected.
> 
Hi,

Thanks for catching it, this is a serious issue.

Does not the diff should be ?

-               dst->bitlen = af_bit_len(family);
+               dst->bitlen = af_bit_len(dst->family);

Also you can use 'git send-email' to send separate patchs as email,
instead of attaching them.

Regards,

next prev parent reply	other threads:[~2015-03-21  6:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <ec4611159b474e158079d8d528e71030@BRMWP-EXMB11.corp.brocade.com>
     [not found] ` <20150320160819.1477223d@uryu.home.lan>
2015-03-21  4:14   ` contributions to iproute2 Joe Harvell
2015-03-21  6:25     ` Vadim Kochan [this message]
2015-03-21  4:23   ` contributions to iproute2 (resend with patches fixed) Joe Harvell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150321062537.GA23505@angus-think.lan \
    --to=vadim4j@gmail$(echo .)com \
    --cc=jharvell@dogpad$(echo .)tk \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=shemming@brocade$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox