Subject: Re: [PATCH v9 tip 5/9] tracing: allow BPF programs to call bpf_trace_printk()

From: Ingo Molnar <[email-masked]>
Date: Sun, 22 Mar 2015 12:10:40 +0100

* Alexei Starovoitov <ast-uqk4Ao+rVK5Wk0Htik3J/[email-masked]> wrote:

> +static const struct bpf_func_proto bpf_trace_printk_proto = {
> +	.func = bpf_trace_printk,
> +	.gpl_only = true,
> +	.ret_type = RET_INTEGER,
> +	.arg1_type = ARG_PTR_TO_STACK,
> +	.arg2_type = ARG_CONST_STACK_SIZE,
> +};

A nit, please align such initializations vertically, for more 
readability:

static const struct bpf_func_proto bpf_trace_printk_proto = {
	.func		= bpf_trace_printk,
	.gpl_only	= true,
	.ret_type	= RET_INTEGER,
	.arg1_type	= ARG_PTR_TO_STACK,
	.arg2_type	= ARG_CONST_STACK_SIZE,
};

(this applies to other patches as well.)

Thanks,

	Ingo