Subject: Re: [PATCH net 1/4 v2] ipvlan: fix addr hash list corruption

From: Jiri Benc <[email-masked]>
Date: Sat, 28 Mar 2015 19:17:06 +0100

On Fri, 27 Mar 2015 17:16:49 -0700, Mahesh Bandewar wrote:
> On Fri, Mar 27, 2015 at 10:30 AM, Jiri Benc <[email-masked]> wrote:
> >  void ipvlan_ht_addr_del(struct ipvl_addr *addr, bool sync)
> >  {
> > -       hlist_del_rcu(&addr->hlnode);
> > +       hlist_del_init_rcu(&addr->hlnode);
> Though this fixes the current crash problem; the duplicate addition in
> the hash-table is still open. I would still prefer it to be protected
> by hlist_unhashed() check.

It cannot happen but whatever, there's no harm in such check. Just sent
a new version.

 Jiri

-- 
Jiri Benc