From: Steffen Klassert <steffen.klassert@secunet•com>
To: shengyong <shengyong1@huawei•com>
Cc: <davem@davemloft•net>, <netdev@vger•kernel.org>,
<yangyingliang@huawei•com>, <hannes@redhat•com>
Subject: [PATCH RFC 3/3] ipv6: Don't update pmtu on uncached routes.
Date: Mon, 30 Mar 2015 12:34:40 +0200 [thread overview]
Message-ID: <20150330103439.GL3311@secunet.com> (raw)
In-Reply-To: <20150330103210.GI3311@secunet.com>
A pmtu update on an uncached route will delete the
original route after expiration time is elapsed.
As a result, the host is not reachable any more.
All routes where pmtu discovery can happen are
cached now, so it is ok to refuse pmtu updates
on uncached routes.
Signed-off-by: Steffen Klassert <steffen.klassert@secunet•com>
---
net/ipv6/route.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index e4b24c8..e0c6ac9 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -1174,7 +1174,8 @@ static void ip6_rt_update_pmtu(struct dst_entry *dst, struct sock *sk,
struct rt6_info *rt6 = (struct rt6_info *)dst;
dst_confirm(dst);
- if (mtu < dst_mtu(dst) && rt6->rt6i_dst.plen == 128) {
+ if (mtu < dst_mtu(dst) && rt6->rt6i_dst.plen == 128 &&
+ (rt6->rt6i_flags & RTF_CACHE)) {
struct net *net = dev_net(dst->dev);
rt6->rt6i_flags |= RTF_MODIFIED;
--
1.9.1
next prev parent reply other threads:[~2015-03-30 10:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 8:20 Question: should local address be expired when updating PMTU? shengyong
2015-02-02 21:31 ` David Miller
2015-02-03 0:52 ` Alex Gartrell
2015-02-03 1:28 ` shengyong
2015-02-03 2:10 ` Calvin Owens
2015-02-03 3:21 ` shengyong
2015-02-03 9:28 ` Steffen Klassert
2015-02-03 10:54 ` shengyong
2015-02-03 12:01 ` Steffen Klassert
2015-02-04 1:59 ` shengyong
2015-02-05 7:21 ` Steffen Klassert
2015-02-27 2:37 ` shengyong
2015-02-27 10:32 ` Steffen Klassert
2015-03-30 10:32 ` Steffen Klassert
2015-03-30 10:33 ` [PATCH RFC 1/3] ipv6: Fix after pmtu events dissapearing host routes Steffen Klassert
2015-03-30 11:15 ` Sheng Yong
2015-03-30 18:24 ` Martin Lau
2015-04-01 8:09 ` Steffen Klassert
2015-03-30 10:33 ` [PATCH RFC 2/3] ipv6: Extend the route lookups to low priority metrics Steffen Klassert
2015-03-30 10:34 ` Steffen Klassert [this message]
2015-03-30 11:13 ` Question: should local address be expired when updating PMTU? Sheng Yong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150330103439.GL3311@secunet.com \
--to=steffen.klassert@secunet$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=hannes@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shengyong1@huawei$(echo .)com \
--cc=yangyingliang@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox