Subject: Re: [PATCH 5/7] ssb: Use bool function return values of true/false not 1/0

From: Michael Büsch <[email-masked]>
Date: Mon, 30 Mar 2015 19:49:01 +0200

On Mon, 30 Mar 2015 10:43:21 -0700
Joe Perches <[email-masked]> wrote:

> Use the normal return values for bool functions
> 
> Signed-off-by: Joe Perches <[email-masked]>
> ---
>  drivers/ssb/driver_gige.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ssb/driver_gige.c b/drivers/ssb/driver_gige.c
> index e973405..ebee6b0 100644
> --- a/drivers/ssb/driver_gige.c
> +++ b/drivers/ssb/driver_gige.c
> @@ -242,7 +242,7 @@ static int ssb_gige_probe(struct ssb_device *sdev,
>  bool pdev_is_ssb_gige_core(struct pci_dev *pdev)
>  {
>  	if (!pdev->resource[0].name)
> -		return 0;
> +		return false;
>  	return (strcmp(pdev->resource[0].name, SSB_GIGE_MEM_RES_NAME) == 0);
>  }
>  EXPORT_SYMBOL(pdev_is_ssb_gige_core);

Looks good.

Signed-off-by: Michael Buesch <[email-masked]>

Kalle, can you take this one, please?

-- 
Michael