Subject: Re: [PATCH net-next v4 07/24] switchdev: add port vlan obj

From: Jiri Pirko <[email-masked]>
Date: Mon, 13 Apr 2015 15:27:03 +0200

Mon, Apr 13, 2015 at 03:16:25PM CEST, [email-masked] wrote:
>Mon, Apr 13, 2015 at 08:17:01AM CEST, [email-masked] wrote:
>>From: Scott Feldman <[email-masked]>
>>
>>VLAN obj has flags (PVID and untagged) as well as start and end vid ranges.
>>The swdev driver can optimize programing the device using the ranges.
>>
>>Signed-off-by: Scott Feldman <[email-masked]>
>>---
>> include/net/switchdev.h |    8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>>diff --git a/include/net/switchdev.h b/include/net/switchdev.h
>>index f5f7733..d3cc8eb 100644
>>--- a/include/net/switchdev.h
>>+++ b/include/net/switchdev.h
>>@@ -45,12 +45,20 @@ struct fib_info;
>> 
>> enum swdev_obj_id {
>> 	SWDEV_OBJ_UNDEFINED,
>>+	SWDEV_OBJ_PORT_VLAN,
>> };
>> 
>> struct swdev_obj {
>> 	enum swdev_obj_id id;
>> 	enum swdev_trans trans;
>> 	u32 flags;
>>+	union {
>>+		struct swdev_obj_vlan {			/* PORT_VLAN */
>>+			u16 flags;
>>+			u16 vid_start;
>>+			u16 vid_end;
>>+		} vlan;
>>+	};
>
>Same here. Please squash this with the next patch.

I mean 09. The infrastructure should be first, usage (by driver) after
that.

>> };
>> /**
>>-- 
>>1.7.10.4