From: Stephen Hemminger <stephen@networkplumber•org>
To: Sebastian Poehn <sebastian.poehn@gmail•com>
Cc: David Miller <davem@davemloft•net>,
netdev@vger•kernel.org, fw@strlen•de, eric.dumazet@gmail•com
Subject: Re: [PATCH] ip_forward: Drop frames with attached skb->sk
Date: Mon, 13 Apr 2015 23:07:14 -0700 [thread overview]
Message-ID: <20150413230714.2cf40794@urahara> (raw)
In-Reply-To: <1428990724.6812.8.camel@googlemail.com>
On Tue, 14 Apr 2015 07:52:04 +0200
Sebastian Poehn <sebastian.poehn@gmail•com> wrote:
>
> + /* this should happen neither */
> + if (unlikely(skb->sk))
> + goto drop;
> +
With gcc, all goto's are already treated as unlikely().
next prev parent reply other threads:[~2015-04-14 6:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 5:52 [PATCH] ip_forward: Drop frames with attached skb->sk Sebastian Poehn
2015-04-14 6:07 ` Stephen Hemminger [this message]
2015-04-14 6:18 ` Sebastian Poehn
2015-04-14 16:50 ` David Miller
2015-04-14 6:33 ` yzhu1
2015-04-14 6:40 ` Sebastian Poehn
2015-04-14 11:54 ` Eric Dumazet
2015-04-14 18:23 ` David Miller
2015-04-15 7:32 ` Sebastian Poehn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150413230714.2cf40794@urahara \
--to=stephen@networkplumber$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sebastian.poehn@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox