From: Martin KaFai Lau <kafai@fb•com>
To: David Miller <davem@davemloft•net>
Cc: <netdev@vger•kernel.org>, <hannes@stressinduktion•org>,
<kernel-team@fb•com>
Subject: Re: [RFC PATCH 06/10] ipv6: Avoid deleting RTF_CACHE route from ip6_route_del()
Date: Mon, 20 Apr 2015 12:33:05 -0700 [thread overview]
Message-ID: <20150420193304.GD2416462@devbig242.prn2.facebook.com> (raw)
In-Reply-To: <20150420.142305.507346652058648202.davem@davemloft.net>
On Mon, Apr 20, 2015 at 02:23:05PM -0400, David Miller wrote:
> From: Martin KaFai Lau <kafai@fb•com>
> Date: Fri, 10 Apr 2015 18:54:09 -0700
>
> > Before patch 'Allow pmtu update on /128 via gateway route',
> > RTF_CACHE route was not created for DST_HOST. It also requires changes on both
> > delete code path and rt6_select() code patch.
> >
> > This patch fixes the delete code path to avoid deleting the RTF_CACHE
> > route by 'ip -6 r del...'
> >
> > Signed-off-by: Martin KaFai Lau <kafai@fb•com>
> > Reviewed-by: Hannes Frederic Sowa <hannes@stressinduktion•org>
>
> If a cached route was created in response to say a PMTU event, and
> it's a clone/copy/cow of the route we are being asked to delete,
> it absolutely should be removed.
>
> In fact this is a critically important aspect of removing routes
> from the table.
When a non-clone routes are removed, its clones are removed together by
fib6_prune_clones() in fib6_del().
Hence, 'ip -6 r del' will remove a route and its clones.
'ip -6 r flush table cache will only remove RTF_CACHE routes.
I will fix up the commit message.
Thanks,
--Martin
next prev parent reply other threads:[~2015-04-20 19:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-11 1:54 [RFC PATCH 00/10] ipv6: Only create RTF_CACHE route after encountering pmtu exception Martin KaFai Lau
2015-04-11 1:54 ` [RFC PATCH 01/10] ipv6: Remove external dependency on rt6i_dst and rt6i_src Martin KaFai Lau
2015-04-11 1:54 ` [RFC PATCH 02/10] ipv6: Remove external dependency on rt6i_gateway and RTF_ANYCAST Martin KaFai Lau
2015-04-11 1:54 ` [RFC PATCH 03/10] ipv6: Combine rt6_alloc_cow and rt6_alloc_clone Martin KaFai Lau
2015-04-11 1:54 ` [RFC PATCH 04/10] ipv6: Only create RTF_CACHE routes after encountering pmtu exception Martin KaFai Lau
2015-04-20 18:27 ` David Miller
2015-04-20 18:28 ` David Miller
2015-04-11 1:54 ` [RFC PATCH 05/10] ipv6: Allow pmtu update on /128 via gateway route Martin KaFai Lau
2015-04-11 1:54 ` [RFC PATCH 06/10] ipv6: Avoid deleting RTF_CACHE route from ip6_route_del() Martin KaFai Lau
2015-04-20 18:23 ` David Miller
2015-04-20 19:33 ` Martin KaFai Lau [this message]
2015-04-20 19:37 ` David Miller
2015-04-11 1:54 ` [RFC PATCH 07/10] ipv6: Extend the route lookups to low priority metrics Martin KaFai Lau
2015-04-11 1:54 ` [RFC PATCH 08/10] ipv6: Do not use inetpeer when creating RTF_CACHE route for /128 via gateway entry Martin KaFai Lau
2015-04-11 1:54 ` [RFC PATCH 09/10] ipv6: Break up ip6_rt_copy() Martin KaFai Lau
2015-04-11 1:54 ` [RFC PATCH 10/10] ipv6: Create percpu rt6_info Martin KaFai Lau
2015-04-20 18:29 ` [RFC PATCH 00/10] ipv6: Only create RTF_CACHE route after encountering pmtu exception David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420193304.GD2416462@devbig242.prn2.facebook.com \
--to=kafai@fb$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=hannes@stressinduktion$(echo .)org \
--cc=kernel-team@fb$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox