Subject: Re: [PATCH V2] net: stmmac: use msleep instead of udelay for gpio reset

From: Michael Trimarchi <[email-masked]>
Date: Wed, 22 Apr 2015 01:13:47 +0200

Hi

On Tue, Apr 21, 2015 at 05:35:40PM -0400, David Miller wrote:
> From: Michael Trimarchi <[email-masked]>
> Date: Tue, 21 Apr 2015 13:16:13 +0200
> 
> > -			udelay(data->delays[0]);
>  ...
> > +			msleep(max(1U, data->delays[0] / 1000));
> 
> That looks very ugly with that max() expression in there.
>

Is fine for you a DIV_ROUND_UP?

> Please find some clean way to get rid of it if you want to
> make this conversion.
>

Agree, I will repost it

Michael

> Thanks.

-- 
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |